* [PATCH] b43: Force-wake queues on init
@ 2009-09-10 18:31 Michael Buesch
2009-09-10 18:34 ` Luis R. Rodriguez
0 siblings, 1 reply; 3+ messages in thread
From: Michael Buesch @ 2009-09-10 18:31 UTC (permalink / raw)
To: John W. Linville; +Cc: Broadcom Wireless, linux-wireless, Albert Herranz
Force wake the mac80211 queues on init.
Under rare circumstances they may be stopped, if a DMA error or
something else causes a device reset while a queue was stopped.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/main.c 2009-09-10 20:13:54.000000000 +0200
+++ wireless-testing/drivers/net/wireless/b43/main.c 2009-09-10 20:26:43.000000000 +0200
@@ -4326,6 +4326,8 @@ static int b43_wireless_core_init(struct
b43_upload_card_macaddress(dev);
b43_security_init(dev);
+ ieee80211_wake_queues(dev->wl->hw);
+
b43_set_status(dev, B43_STAT_INITIALIZED);
out:
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] b43: Force-wake queues on init
2009-09-10 18:31 [PATCH] b43: Force-wake queues on init Michael Buesch
@ 2009-09-10 18:34 ` Luis R. Rodriguez
2009-09-10 18:38 ` Michael Buesch
0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2009-09-10 18:34 UTC (permalink / raw)
To: Michael Buesch
Cc: John W. Linville, Albert Herranz, linux-wireless,
Broadcom Wireless
On Thu, Sep 10, 2009 at 11:31 AM, Michael Buesch <mb@bu3sch.de> wrote:
> Force wake the mac80211 queues on init.
> Under rare circumstances they may be stopped, if a DMA error or
> something else causes a device reset while a queue was stopped.
So this is a work around for some unknown issue on the driver?
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] b43: Force-wake queues on init
2009-09-10 18:34 ` Luis R. Rodriguez
@ 2009-09-10 18:38 ` Michael Buesch
0 siblings, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2009-09-10 18:38 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: John W. Linville, Albert Herranz, linux-wireless,
Broadcom Wireless
On Thursday 10 September 2009 20:34:36 Luis R. Rodriguez wrote:
> On Thu, Sep 10, 2009 at 11:31 AM, Michael Buesch <mb@bu3sch.de> wrote:
> > Force wake the mac80211 queues on init.
> > Under rare circumstances they may be stopped, if a DMA error or
> > something else causes a device reset while a queue was stopped.
>
> So this is a work around for some unknown issue on the driver?
No, it's a fix for a bug that should not trigger in practice very often.
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-10 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-10 18:31 [PATCH] b43: Force-wake queues on init Michael Buesch
2009-09-10 18:34 ` Luis R. Rodriguez
2009-09-10 18:38 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).