From: Frans Pop <elendil@planet.nl>
To: reinette chatre <reinette.chatre@intel.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
Larry Finger <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
"cl@linux-foundation.org" <cl@linux-foundation.org>,
"Krauss, Assaf" <assaf.krauss@intel.com>,
Johannes Berg <johannes@sipsolutions.net>,
"Abbas, Mohamed" <mohamed.abbas@intel.com>
Subject: Re: iwlagn: order 2 page allocation failures
Date: Thu, 10 Sep 2009 20:43:13 +0200 [thread overview]
Message-ID: <200909102043.17883.elendil@planet.nl> (raw)
In-Reply-To: <1252606547.30150.304.camel@rc-desk>
On Thursday 10 September 2009, reinette chatre wrote:
> From: Reinette Chatre <reinette.chatre@intel.com>
> Date: Wed, 9 Sep 2009 15:41:00 -0700
> Subject: [PATCH] iwlwifi: reduce noise when skb allocation fails
Looks good to me (from a user's perspective).
IIUC the first message is now only displayed if IWL debugging is
explicitly enabled, and the second only if there really is danger of it
affecting data transfer and has been made more informative too.
It seems to me that, with debugging enabled, the "Failed to allocate SKB
buffer." message may get repeated, but I guess that's minor.
One nitpick. As you've made the message into sentences, "Only %u free
buffers remaining" should IMO also end with a period.
Thanks,
FJP
next prev parent reply other threads:[~2009-09-10 18:43 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 7:40 iwlagn: order 2 page allocation failures Frans Pop
2009-09-06 8:14 ` Pekka Enberg
2009-09-06 8:28 ` Frans Pop
2009-09-06 8:35 ` Pekka Enberg
2009-09-08 10:54 ` Mel Gorman
2009-09-08 11:11 ` Pekka Enberg
2009-09-08 14:17 ` John W. Linville
2009-09-08 14:59 ` Larry Finger
2009-09-09 15:04 ` Mel Gorman
2009-09-09 15:59 ` Frans Pop
2009-09-09 16:55 ` Mel Gorman
2009-09-09 17:19 ` Frans Pop
2009-09-16 14:36 ` Frans Pop
2009-09-16 15:02 ` Mel Gorman
2009-09-16 15:37 ` Frans Pop
2009-09-16 16:26 ` reinette chatre
2009-09-09 20:05 ` reinette chatre
2009-09-10 1:48 ` Frans Pop
2009-09-10 9:02 ` Mel Gorman
2009-09-10 18:15 ` reinette chatre
2009-09-10 18:43 ` Frans Pop [this message]
2009-09-10 18:50 ` reinette chatre
2009-09-11 8:45 ` Mel Gorman
2009-09-11 16:14 ` reinette chatre
2009-09-10 21:14 ` reinette chatre
2009-09-11 8:47 ` Mel Gorman
2009-09-14 3:01 ` Zhu Yi
2009-09-14 13:06 ` Mel Gorman
2009-09-15 8:30 ` alloc skb based on a given data buffer Zhu Yi
2009-09-15 8:33 ` David Miller
2009-09-15 8:57 ` Zhu Yi
2009-09-15 9:09 ` David Miller
2009-09-15 9:15 ` Zhu Yi
2009-09-15 15:30 ` Johannes Berg
2009-09-15 21:16 ` David Miller
2009-09-19 5:56 ` Johannes Berg
2009-09-14 15:42 ` iwlagn: order 2 page allocation failures Christoph Lameter
2009-09-14 17:59 ` Mel Gorman
2009-09-14 18:04 ` Christoph Lameter
2009-09-10 8:18 ` Pekka Enberg
2009-09-10 12:34 ` Mel Gorman
2009-09-10 12:39 ` Pekka Enberg
2009-09-10 12:58 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909102043.17883.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=assaf.krauss@intel.com \
--cc=cl@linux-foundation.org \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mel@csn.ul.ie \
--cc=mohamed.abbas@intel.com \
--cc=penberg@cs.helsinki.fi \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).