Re: [PATCH] cfg80211: allow scanning on specified frequencies when using wext-compatibility

[Holger Schurig <hs4233@mail.mn-solutions.de>]

> This is a bit weird -- this way you don't report errors if the
> user specified frequencies that don't exist.

Couldn't / shouldn't this done in user-space, e.g. after checking
IWRANGE.


> Also, are you sure that it has to be a frequency as opposed to
> a channel number?

I'm not totally sure, because there's nowhere any documentation
about the exact meanings of fields in "struct iw_freq". My patch
for wpa_supplicant's driver_wext.c only put's a frequency there:

+        req.channel_list[i].m = params->freqs[i] * 100000;
+        req.channel_list[i].e = 1;
+        req.channel_list[i].i = i;
+        req.channel_list[i].flags = 0;

But now that you bring this into my mind, I should have looked
at another consumer of "struct iw_freq", e.g. I should use
cfg80211_wext_freq() like cfg80211_wext_siwfreq() ?!?

I'll prepare some patch.

-- 
http://www.holgerschurig.de