* Re: [PATCH3]Add analog switch support [not found] <1252956934.4696.23.camel@luzifer.localnet> @ 2009-09-14 19:43 ` Gábor Stefanik 2009-09-14 19:56 ` Thomas Ilnseher 0 siblings, 1 reply; 6+ messages in thread From: Gábor Stefanik @ 2009-09-14 19:43 UTC (permalink / raw) To: Thomas Ilnseher, John Linville; +Cc: Broadcom Wireless, linux-wireless Always send patches to John Linville, and CC linux-wireless. On Mon, Sep 14, 2009 at 9:35 PM, Thomas Ilnseher <illth@gmx.de> wrote: > As I've seen Gàbor's patch, I noticed that my previous patch was > bullshit. This patch should work: > > Signed-off-by: Thomas Ilnseher <illth@gmx.de> > > diff -uNr b/drivers/net/wireless/b43/phy_lp.c a/drivers/net/wireless/b43/phy_lp.c > --- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000 +0200 > +++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573 +0200 > @@ -2228,6 +2228,16 @@ > return B43_TXPWR_RES_DONE; > } > > +void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on) > +{ > + if (on) { > + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8); > + } else { > + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007); > + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007); > + } > +} > + > const struct b43_phy_operations b43_phyops_lp = { > .allocate = b43_lpphy_op_allocate, > .free = b43_lpphy_op_free, > @@ -2239,7 +2249,7 @@ > .radio_read = b43_lpphy_op_radio_read, > .radio_write = b43_lpphy_op_radio_write, > .software_rfkill = b43_lpphy_op_software_rfkill, > - .switch_analog = b43_phyop_switch_analog_generic, > + .switch_analog = b43_lpphy_op_switch_analog, > .switch_channel = b43_lpphy_op_switch_channel, > .get_default_chan = b43_lpphy_op_get_default_chan, > .set_rx_antenna = b43_lpphy_op_set_rx_antenna, > > > _______________________________________________ > Bcm43xx-dev mailing list > Bcm43xx-dev@lists.berlios.de > https://lists.berlios.de/mailman/listinfo/bcm43xx-dev > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH3]Add analog switch support 2009-09-14 19:43 ` [PATCH3]Add analog switch support Gábor Stefanik @ 2009-09-14 19:56 ` Thomas Ilnseher 2009-09-14 20:18 ` Larry Finger 2009-09-14 20:22 ` Thomas Ilnseher 0 siblings, 2 replies; 6+ messages in thread From: Thomas Ilnseher @ 2009-09-14 19:56 UTC (permalink / raw) To: John Linville; +Cc: Broadcom Wireless, linux-wireless On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote: > Always send patches to John Linville, and CC linux-wireless. Ok, the last try ... As I've seen Gàbor's patch, I noticed that my previous patch was bullshit. This patch should work: (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore) Signed-off-by: Thomas Ilnseher <illth@gmx.de> diff -uNr b/drivers/net/wireless/b43/phy_lp.c a/drivers/net/wireless/b43/phy_lp.c --- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000 +0200 +++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573 +0200 @@ -2228,6 +2228,16 @@ return B43_TXPWR_RES_DONE; } +void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on) +{ + if (on) { + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8); + } else { + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007); + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007); + } +} + const struct b43_phy_operations b43_phyops_lp = { .allocate = b43_lpphy_op_allocate, .free = b43_lpphy_op_free, @@ -2239,7 +2249,7 @@ .radio_read = b43_lpphy_op_radio_read, .radio_write = b43_lpphy_op_radio_write, .software_rfkill = b43_lpphy_op_software_rfkill, - .switch_analog = b43_phyop_switch_analog_generic, + .switch_analog = b43_lpphy_op_switch_analog, .switch_channel = b43_lpphy_op_switch_channel, .get_default_chan = b43_lpphy_op_get_default_chan, .set_rx_antenna = b43_lpphy_op_set_rx_antenna, ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH3]Add analog switch support 2009-09-14 19:56 ` Thomas Ilnseher @ 2009-09-14 20:18 ` Larry Finger 2009-09-15 12:57 ` John W. Linville 2009-09-14 20:22 ` Thomas Ilnseher 1 sibling, 1 reply; 6+ messages in thread From: Larry Finger @ 2009-09-14 20:18 UTC (permalink / raw) To: Thomas Ilnseher; +Cc: John Linville, Broadcom Wireless, linux-wireless Thomas Ilnseher wrote: > On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote: >> Always send patches to John Linville, and CC linux-wireless. > Ok, the last try ... > > As I've seen Gàbor's patch, I noticed that my previous patch was > bullshit. This patch should work: > > (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore) > > Signed-off-by: Thomas Ilnseher <illth@gmx.de> > A few points about patch formatting. The subject of the submittal message should be of the form "[PATCH] component: Description". For this one, something like "[PATCH] b43: Add LP PHY analog switch support" would be appropriate. If multiple versions are needed, indicate that a previous one is superceded by [PATCH V2] ..., etc. There should be a line containing --- after the last signed-off-by line. Anything between the beginning of the e-mail and the --- line becomes part of the permanent record if the patch is accepted. Usually quoted material and words like bullshit are avoided. Not always, but usually. Between the --- line and the start of the patch, you can place instructions to Linville regarding the circumstances of the patch and its priority. Such directions are useful to distinguish an improvement that should wait for the next merge period from a bug fix that should be sent upstream ASAP. In this case, the patch fixes a system crash on some platforms and should be applied now. Larry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH3]Add analog switch support 2009-09-14 20:18 ` Larry Finger @ 2009-09-15 12:57 ` John W. Linville 0 siblings, 0 replies; 6+ messages in thread From: John W. Linville @ 2009-09-15 12:57 UTC (permalink / raw) To: Larry Finger; +Cc: Thomas Ilnseher, Broadcom Wireless, linux-wireless On Mon, Sep 14, 2009 at 03:18:24PM -0500, Larry Finger wrote: > Thomas Ilnseher wrote: > > On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote: > >> Always send patches to John Linville, and CC linux-wireless. > > Ok, the last try ... > > > > As I've seen Gàbor's patch, I noticed that my previous patch was > > bullshit. This patch should work: > > > > (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore) > > > > Signed-off-by: Thomas Ilnseher <illth@gmx.de> > > > > A few points about patch formatting. > > The subject of the submittal message should be of the form "[PATCH] > component: Description". For this one, something like "[PATCH] b43: > Add LP PHY analog switch support" would be appropriate. If multiple > versions are needed, indicate that a previous one is superceded by > [PATCH V2] ..., etc. > > There should be a line containing --- after the last signed-off-by line. > > Anything between the beginning of the e-mail and the --- line becomes > part of the permanent record if the patch is accepted. Usually quoted > material and words like bullshit are avoided. Not always, but usually. > > Between the --- line and the start of the patch, you can place > instructions to Linville regarding the circumstances of the patch and > its priority. Such directions are useful to distinguish an improvement > that should wait for the next merge period from a bug fix that should > be sent upstream ASAP. In this case, the patch fixes a system crash on > some platforms and should be applied now. Above is a good summary. I usually refer people here (which has mostly the same information): http://linux.yyz.us/patch-format.html Hth! John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH3]Add analog switch support 2009-09-14 19:56 ` Thomas Ilnseher 2009-09-14 20:18 ` Larry Finger @ 2009-09-14 20:22 ` Thomas Ilnseher 2009-09-14 20:47 ` Michael Buesch 1 sibling, 1 reply; 6+ messages in thread From: Thomas Ilnseher @ 2009-09-14 20:22 UTC (permalink / raw) To: John Linville; +Cc: Broadcom Wireless, linux-wireless I can now confirm that the patch below DOES compile, and even works. Here is the dmesg output on my router: root@OpenWrt:/tmp# dmesg b43-phy1: Broadcom 5354 WLAN found (core revision 13) b43-phy1 debug: Found PHY: Analog 6, Type 5, Revision 0 b43-phy1 debug: Found Radio: Manuf 0x17F, Version 0x2062, Revision 1 phy1: Selected rate control algorithm 'minstrel' Broadcom 43xx driver loaded [ Features: PL, Firmware-ID: FW13 ] b43 ssb0:3: firmware: requesting b43/ucode13.fw b43 ssb0:3: firmware: requesting b43/lp0initvals13.fw b43 ssb0:3: firmware: requesting b43/lp0bsinitvals13.fw b43-phy1: Loading firmware version 410.2160 (2007-05-26 15:32:10) b43-phy1 debug: b2062: Using crystal tab entry 19200 kHz. b43-phy1 debug: Chip initialized b43-phy1 debug: 64-bit DMA initialized Registered led device: b43-phy1::tx Registered led device: b43-phy1::rx b43-phy1 debug: Wireless interface started b43-phy1 debug: Adding Interface type 2 wlan0: direct probe to AP XXXXXXXX (try 1) wlan0 direct probe responded wlan0: authenticate with AP XXXXXXXX (try 1) wlan0: authenticated wlan0: associate with AP XXXXXXXX (try 1) wlan0: RX AssocResp from XXXXXXXX (capab=0x431 status=0 aid=1) wlan0: associated b43-phy1 debug: Using hardware based encryption for keyidx: 0, mac: XXXXXXXX root@OpenWrt:/tmp# iwconfig 2> /dev/null wlan0 IEEE 802.11bg ESSID:"tommy" Mode:Managed Frequency:2.412 GHz Access Point: XX:XX:XX:XX:XX:XX Bit Rate=11 Mb/s Tx-Power=20 dBm Retry long limit:7 RTS thr:off Fragment thr:off Encryption key:off Power Management:off Link Quality=70/70 Signal level=3 dBm Rx invalid nwid:0 Rx invalid crypt:0 Rx invalid frag:0 Tx excessive retries:0 Invalid misc:0 Missed beacon:0 On Mo, 2009-09-14 at 21:56 +0200, Thomas Ilnseher wrote: > On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote: > > Always send patches to John Linville, and CC linux-wireless. > Ok, the last try ... > > As I've seen Gàbor's patch, I noticed that my previous patch was > bullshit. This patch should work: > > (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore) > > Signed-off-by: Thomas Ilnseher <illth@gmx.de> > > diff -uNr b/drivers/net/wireless/b43/phy_lp.c > a/drivers/net/wireless/b43/phy_lp.c > --- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000 > +0200 > +++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573 > +0200 > @@ -2228,6 +2228,16 @@ > return B43_TXPWR_RES_DONE; > } > > +void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on) > +{ > + if (on) { > + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8); > + } else { > + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007); > + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007); > + } > +} > + > const struct b43_phy_operations b43_phyops_lp = { > .allocate = b43_lpphy_op_allocate, > .free = b43_lpphy_op_free, > @@ -2239,7 +2249,7 @@ > .radio_read = b43_lpphy_op_radio_read, > .radio_write = b43_lpphy_op_radio_write, > .software_rfkill = b43_lpphy_op_software_rfkill, > - .switch_analog = b43_phyop_switch_analog_generic, > + .switch_analog = b43_lpphy_op_switch_analog, > .switch_channel = b43_lpphy_op_switch_channel, > .get_default_chan = b43_lpphy_op_get_default_chan, > .set_rx_antenna = b43_lpphy_op_set_rx_antenna, > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH3]Add analog switch support 2009-09-14 20:22 ` Thomas Ilnseher @ 2009-09-14 20:47 ` Michael Buesch 0 siblings, 0 replies; 6+ messages in thread From: Michael Buesch @ 2009-09-14 20:47 UTC (permalink / raw) To: bcm43xx-dev; +Cc: Thomas Ilnseher, John Linville, linux-wireless On Monday 14 September 2009 22:22:57 Thomas Ilnseher wrote: > I can now confirm that the patch below DOES compile, and even works. So can you send a version which conforms to our patch submission standards as larry explained? -- Greetings, Michael. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-09-15 13:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1252956934.4696.23.camel@luzifer.localnet>
2009-09-14 19:43 ` [PATCH3]Add analog switch support Gábor Stefanik
2009-09-14 19:56 ` Thomas Ilnseher
2009-09-14 20:18 ` Larry Finger
2009-09-15 12:57 ` John W. Linville
2009-09-14 20:22 ` Thomas Ilnseher
2009-09-14 20:47 ` Michael Buesch
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).