From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Thomas Ilnseher <illth@gmx.de>,
Broadcom Wireless <bcm43xx-dev@lists.berlios.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH3]Add analog switch support
Date: Tue, 15 Sep 2009 08:57:35 -0400 [thread overview]
Message-ID: <20090915125734.GA2651@tuxdriver.com> (raw)
In-Reply-To: <4AAEA510.5060606@lwfinger.net>
On Mon, Sep 14, 2009 at 03:18:24PM -0500, Larry Finger wrote:
> Thomas Ilnseher wrote:
> > On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote:
> >> Always send patches to John Linville, and CC linux-wireless.
> > Ok, the last try ...
> >
> > As I've seen Gàbor's patch, I noticed that my previous patch was
> > bullshit. This patch should work:
> >
> > (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore)
> >
> > Signed-off-by: Thomas Ilnseher <illth@gmx.de>
> >
>
> A few points about patch formatting.
>
> The subject of the submittal message should be of the form "[PATCH]
> component: Description". For this one, something like "[PATCH] b43:
> Add LP PHY analog switch support" would be appropriate. If multiple
> versions are needed, indicate that a previous one is superceded by
> [PATCH V2] ..., etc.
>
> There should be a line containing --- after the last signed-off-by line.
>
> Anything between the beginning of the e-mail and the --- line becomes
> part of the permanent record if the patch is accepted. Usually quoted
> material and words like bullshit are avoided. Not always, but usually.
>
> Between the --- line and the start of the patch, you can place
> instructions to Linville regarding the circumstances of the patch and
> its priority. Such directions are useful to distinguish an improvement
> that should wait for the next merge period from a bug fix that should
> be sent upstream ASAP. In this case, the patch fixes a system crash on
> some platforms and should be applied now.
Above is a good summary. I usually refer people here (which has
mostly the same information):
http://linux.yyz.us/patch-format.html
Hth!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-09-15 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1252956934.4696.23.camel@luzifer.localnet>
2009-09-14 19:43 ` [PATCH3]Add analog switch support Gábor Stefanik
2009-09-14 19:56 ` Thomas Ilnseher
2009-09-14 20:18 ` Larry Finger
2009-09-15 12:57 ` John W. Linville [this message]
2009-09-14 20:22 ` Thomas Ilnseher
2009-09-14 20:47 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915125734.GA2651@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=illth@gmx.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).