From: Mattia Dongili <malattia@linux.it>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Norbert Preining" <preining@logic.at>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Almer S. Tigelaar" <almer@gnome.org>,
"Matthias Welwarsky" <matze@welwarsky.de>
Subject: Re: [PATCH] sony-laptop: check for rfkill hard block at load time
Date: Fri, 25 Sep 2009 08:04:15 +0900 [thread overview]
Message-ID: <20090924230415.GB29169@kamineko.org> (raw)
In-Reply-To: <4ABBD278.3050207@tuffmail.co.uk>
On Thu, Sep 24, 2009 at 09:11:36PM +0100, Alan Jenkins wrote:
> Gábor Stefanik wrote:
> > On Thu, Sep 24, 2009 at 9:15 PM, Alan Jenkins
> > <alan-jenkins@tuffmail.co.uk> wrote:
> >
...
> >> @@ -1108,6 +1110,10 @@ static int sony_nc_setup_rfkill(struct acpi_device *device,
> >> if (!rfk)
> >> return -ENOMEM;
> >>
> >> + sony_call_snc_handle(0x124, 0x200, &result);
> >>
> >
> > Please define these somewhere, don't use magic numbers.
> >
>
> The rfkill functions are all together in the file, it's not that bad.
> But ok.
>
> There's another bug / missing feature - it doesn't re-read the hard
> states on resume from suspend.
>
> I'll submit two more patches then. I won't convert all of the magic
> numbers though. This isn't hardware I know anything about, and "magic
> numbers" is a good description of some of them -
right and the whole purpose of them is to hit specific code paths
in the DSDT tables. Not sure we would benefit that much from having
names for them.
--
mattia
:wq!
next prev parent reply other threads:[~2009-09-24 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 13:02 rfkill hard state after booting Norbert Preining
2009-09-24 14:07 ` Johannes Berg
2009-09-24 15:01 ` Alan Jenkins
2009-09-24 15:05 ` Johannes Berg
2009-09-24 15:12 ` Alan Jenkins
2009-09-24 17:29 ` Johannes Berg
2009-09-24 19:15 ` [PATCH] sony-laptop: check for rfkill hard block at load time Alan Jenkins
2009-09-24 19:24 ` Gábor Stefanik
2009-09-24 20:11 ` Alan Jenkins
2009-09-24 23:04 ` Mattia Dongili [this message]
2009-09-24 19:27 ` Johannes Berg
2009-09-24 22:38 ` Mattia Dongili
2009-09-25 9:13 ` Alan Jenkins
2009-09-24 16:19 ` rfkill hard state after booting Norbert Preining
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090924230415.GB29169@kamineko.org \
--to=malattia@linux.it \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=almer@gnome.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=matze@welwarsky.de \
--cc=netrolller.3d@gmail.com \
--cc=preining@logic.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).