[rfkill PATCH] default install to $(PREFIX)/sbin

[rfkill PATCH] default install to $(PREFIX)/sbin

[John W. Linville]

The rfkill utility isn't generally useful to normal users, so move it to
/sbin with other system management executables.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index cda48c4..71a6082 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 MAKEFLAGS += --no-print-directory
 
 PREFIX ?= /usr
-BINDIR ?= $(PREFIX)/bin
+SBINDIR ?= $(PREFIX)/sbin
 MANDIR ?= $(PREFIX)/share/man
 
 MKDIR ?= mkdir -p
@@ -48,8 +48,8 @@ check:
 
 install: rfkill rfkill.1.gz
 	@$(NQ) ' INST rfkill'
-	$(Q)$(MKDIR) $(DESTDIR)$(BINDIR)
-	$(Q)$(INSTALL) -m 755 -t $(DESTDIR)$(BINDIR) rfkill
+	$(Q)$(MKDIR) $(DESTDIR)$(SBINDIR)
+	$(Q)$(INSTALL) -m 755 -t $(DESTDIR)$(SBINDIR) rfkill
 	@$(NQ) ' INST rfkill.1'
 	$(Q)$(MKDIR) $(DESTDIR)$(MANDIR)/man1/
 	$(Q)$(INSTALL) -m 644 -t $(DESTDIR)$(MANDIR)/man1/ rfkill.1.gz
-- 
1.6.2.5

Re: [rfkill PATCH] default install to $(PREFIX)/sbin

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

On Tue, 2009-09-29 at 13:41 -0400, John W. Linville wrote:
> The rfkill utility isn't generally useful to normal users, so move it to
> /sbin with other system management executables.

Seems to me that it's kinda useful, it should be possible for most users
to use the event and query interface if the /dev/rfkill permissions are
set up correctly.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [rfkill PATCH] default install to $(PREFIX)/sbin

[John W. Linville]

On Tue, Sep 29, 2009 at 10:34:37PM +0200, Johannes Berg wrote:
> On Tue, 2009-09-29 at 13:41 -0400, John W. Linville wrote:
> > The rfkill utility isn't generally useful to normal users, so move it to
> > /sbin with other system management executables.
> 
> Seems to me that it's kinda useful, it should be possible for most users
> to use the event and query interface if the /dev/rfkill permissions are
> set up correctly.

Sure, but (just like ip, ifconfig, or iwconfig) nothing stops people
from using them in /sbin or /usr/sbin.  It is just a convention for
tools that are more for system management than for day-to-day use.

Hopefully most people will stick with NM or whatever and may stay
completely unaware of the rfkill utility. :-)

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [rfkill PATCH] default install to $(PREFIX)/sbin

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Tue, 2009-09-29 at 17:00 -0400, John W. Linville wrote:
> On Tue, Sep 29, 2009 at 10:34:37PM +0200, Johannes Berg wrote:
> > On Tue, 2009-09-29 at 13:41 -0400, John W. Linville wrote:
> > > The rfkill utility isn't generally useful to normal users, so move it to
> > > /sbin with other system management executables.
> > 
> > Seems to me that it's kinda useful, it should be possible for most users
> > to use the event and query interface if the /dev/rfkill permissions are
> > set up correctly.
> 
> Sure, but (just like ip, ifconfig, or iwconfig) nothing stops people
> from using them in /sbin or /usr/sbin.  It is just a convention for
> tools that are more for system management than for day-to-day use.
> 
> Hopefully most people will stick with NM or whatever and may stay
> completely unaware of the rfkill utility. :-)

So are you going to send an iw patch too? :-)

FWIW I like tools in bin/ since the default paths on most systems for
users don't include sbin/.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [rfkill PATCH] default install to $(PREFIX)/sbin

[John W. Linville]

On Tue, Sep 29, 2009 at 11:02:40PM +0200, Johannes Berg wrote:
> On Tue, 2009-09-29 at 17:00 -0400, John W. Linville wrote:
> > On Tue, Sep 29, 2009 at 10:34:37PM +0200, Johannes Berg wrote:
> > > On Tue, 2009-09-29 at 13:41 -0400, John W. Linville wrote:
> > > > The rfkill utility isn't generally useful to normal users, so move it to
> > > > /sbin with other system management executables.
> > > 
> > > Seems to me that it's kinda useful, it should be possible for most users
> > > to use the event and query interface if the /dev/rfkill permissions are
> > > set up correctly.
> > 
> > Sure, but (just like ip, ifconfig, or iwconfig) nothing stops people
> > from using them in /sbin or /usr/sbin.  It is just a convention for
> > tools that are more for system management than for day-to-day use.
> > 
> > Hopefully most people will stick with NM or whatever and may stay
> > completely unaware of the rfkill utility. :-)
> 
> So are you going to send an iw patch too? :-)

As you wish...on it's way!

> FWIW I like tools in bin/ since the default paths on most systems for
> users don't include sbin/.

FWIW, Fedora has been including it for normal users for a few
releases now.

I agree that it /bin vs /sbin is not strictly necessary, but it is
standard practice.  I guess it does enable some users to either drop
those tools completely from their path or to order their path to
select alternate versions of tools for whatever reason.  Whatever...

I think Fedora will move iw and rfkill to /sbin in any case.
This enables them to be used before /usr is mounted and makes sure
root has them early in his path.  The posted patches are not strictly
necessary for that, but they slightly simplify the install process.
Plus, I think they are more compliant with standard practices.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.