From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bu3sch.de ([62.75.166.246]:54751 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbZJBTiC (ORCPT ); Fri, 2 Oct 2009 15:38:02 -0400 From: Michael Buesch To: Andrew Price Subject: Re: WARNING: at drivers/net/wireless/b43/main.c:3923 b43_wireless_core_stop+0x1c8/0x1d0() Date: Fri, 2 Oct 2009 21:38:02 +0200 Cc: linux-wireless References: <20091002193042.GA3719@plato.andrewprice.me.uk> In-Reply-To: <20091002193042.GA3719@plato.andrewprice.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200910022138.04296.mb@bu3sch.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Friday 02 October 2009 21:30:43 Andrew Price wrote: > Hi, > > I'm seeing this warning when I unplug my wireless card while the > network interface is still up. It doesn't seem to cause any permanent > damage - when I plug it back in I can use the wireless card again. > > I'm using today's mainline kernel as of 0efe5e32 with Michael Buesch's > "b43: Don't use struct wldev after detach" patch added, though I don't > believe that patch is the culprit because the warning triggers without > it too. > > The line it refers to is: > B43_WARN_ON(b43_read32(dev, B43_MMIO_GEN_IRQ_MASK)); This should fix it --- drivers/net/wireless/b43/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- wireless-testing.orig/drivers/net/wireless/b43/main.c +++ wireless-testing/drivers/net/wireless/b43/main.c @@ -3874,6 +3874,7 @@ static struct b43_wldev * b43_wireless_c { struct b43_wl *wl = dev->wl; struct b43_wldev *orig_dev; + u32 mask; redo: if (!dev || b43_status(dev) < B43_STAT_STARTED) @@ -3920,7 +3921,8 @@ redo: goto redo; return dev; } - B43_WARN_ON(b43_read32(dev, B43_MMIO_GEN_IRQ_MASK)); + mask = b43_read32(dev, B43_MMIO_GEN_IRQ_MASK); + B43_WARN_ON(mask != 0xFFFFFFFF && mask); /* Drain the TX queue */ while (skb_queue_len(&wl->tx_queue)) -- Greetings, Michael.