From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Hin-Tak Leung <hintak.leung@gmail.com>,
linux-wireless@vger.kernel.org,
Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH] compat-2.6: adding ethtool.h to compat-2.6.31.h
Date: Wed, 7 Oct 2009 10:45:02 -0400 [thread overview]
Message-ID: <20091007144502.GA22394@tuxdriver.com> (raw)
In-Reply-To: <43e72e890910062240w7b4f0895t7f009b99da8fac40@mail.gmail.com>
On Wed, Oct 07, 2009 at 01:40:04AM -0400, Luis R. Rodriguez wrote:
> On Tue, Oct 6, 2009 at 11:39 PM, Hin-Tak Leung <hintak.leung@gmail.com> wrote:
> > Between 2.6.30 and 2.6.31, linux/netdevice.h started
> > to include linux/ethtool.h (commit b1b67dd45a6b629eb41553856805aaa1614fbb83,
> > "net: factor out ethtool invocation of vlan/macvlan drivers"),
> > and commit 7508e486965b0af13984bc6d9da62a8d8f0dc5f9,
> > "cfg80211: add firmware and hardware version to wiphy", introduces
> > dependency of ETHTOOL_BUSINFO_LEN from linux/ethtool.h
> > to net/cfg80211.h .
>
> John's patch titled "cfg80211: fix compile error from missing
> ethtool.h" seems to address this upstream. I'll wait until he applies
> that to the tree.
As Hin-Tak points-out, linux/netdevice.h is alreadying "doing the needful". :-)
I'll just drop my patch and let this get sorted in compat-wireless.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-10-07 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 3:39 [PATCH] compat-2.6: adding ethtool.h to compat-2.6.31.h Hin-Tak Leung
2009-10-07 3:45 ` Hin-Tak Leung
2009-10-07 5:41 ` Luis R. Rodriguez
2009-10-07 6:30 ` Luis R. Rodriguez
2009-10-07 5:40 ` Luis R. Rodriguez
2009-10-07 14:45 ` John W. Linville [this message]
2009-10-07 15:22 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007144502.GA22394@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hintak.leung@gmail.com \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).