From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
David Miller <davem@davemloft.net>,
Kalle Valo <kalle.valo@iki.fi>,
Dave Young <hidave.darkstar@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] b43: fix ieee80211_rx() context
Date: Sun, 11 Oct 2009 12:35:35 +0200 [thread overview]
Message-ID: <200910111235.36986.mb@bu3sch.de> (raw)
In-Reply-To: <1255257066.4095.66.camel@johannes.local>
On Sunday 11 October 2009 12:31:06 Johannes Berg wrote:
> On Sun, 2009-10-11 at 12:26 +0200, Michael Buesch wrote:
> > On Sunday 11 October 2009 12:19:21 Johannes Berg wrote:
> > > Due to the way it interacts with the networking
> > > stack and other parts of mac80211, ieee80211_rx()
> > > must be called with disabled softirqs.
> >
> > Is this stated in the documentation somewhere?
>
> No. However, there are many things that aren't in the documentation, I'm
> working on a patch to add a note.
Ok, thanks a lot.
> I just wanted to provide a
> rationale for me fixing this bug instead of you.
Since when do we require that in commit messages?
> If you disagree that
> this is an accurate representation, I invite you to summarise the thread
> that caused this miserable situation of a known bug not being fixed for
> a very long time despite appropriate fixes being known in your own words
> for the commit message.
If you'd care _that_ much, you could have just reverted my commit.
Yes, I introduced the regression and I was unable to cook up a fix for it. So the logical
reaction to that would be to revert my commit.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-10-11 10:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 10:19 [PATCH] b43: fix ieee80211_rx() context Johannes Berg
2009-10-11 10:26 ` Michael Buesch
2009-10-11 10:31 ` Johannes Berg
2009-10-11 10:35 ` Michael Buesch [this message]
2009-10-12 7:27 ` Holger Schurig
2009-10-11 10:39 ` David Miller
2009-10-11 11:53 ` Dave Young
2009-10-11 15:59 ` Kalle Valo
2009-10-11 16:02 ` Johannes Berg
2009-10-11 16:08 ` Kalle Valo
2009-10-12 3:08 ` David Miller
2009-10-12 7:49 ` Kalle Valo
2009-10-12 12:29 ` Luciano Coelho
2009-10-12 13:38 ` John W. Linville
2009-10-12 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910111235.36986.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=davem@davemloft.net \
--cc=hidave.darkstar@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).