Re: WARNING: slow-path

[Holger Schurig <hs4233@mail.mn-solutions.de>]

> What happens if you make that last argument NULL instead of
> passing 'dummy' back to it? That makes cfg80211_send_deauth()
> magically do different things w.r.t. locking.

That worked, thanks.


> Johannes, this is _evil_: 

It's not only _evil_, it's also undocumented. I was just
following include/net/cfg80211.h. There is no kernel-doc in the
comments for "cookie", neither in

  [struct cfg80211_ops:]

        int     (*deauth)(struct wiphy *wiphy, struct net_device *dev,
                          struct cfg80211_deauth_request *req,
                          void *cookie);

nor in


void cfg80211_send_deauth(struct net_device *dev, const u8 *buf, size_t len,
                          void *cookie);


so I automatically assumed that I have to provide the "cookie" I
got in my deauth()-handler to cfg80211_send_deauth().

/me says "I can haz a cookie?"

-- 
http://www.holgerschurig.de