Linux wireless drivers development
 help / color / mirror / Atom feed
From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: linux-wireless@vger.kernel.org
Subject: cfg80211 question: impedance mismatch of .connect versus .assoc
Date: Wed, 14 Oct 2009 11:36:03 +0200	[thread overview]
Message-ID: <200910141136.03288.hs4233@mail.mn-solutions.de> (raw)

While playing with .auth/.deauth/.assoc/.disassoc 
versus .connect/.disconnect in libertas, I notices two things 
that makes things a bit hard for me.


BSS list driven vs. not
-----------------------
.auth/.assoc provides the BSSID to connect to. If cfg80211's BSS 
list is empty, it even will do a scan before 
calling .auth/.assoc.

However, for the .connect method this isn't true. .connect just 
get's the SSID.

My problem here is that the CMD_802_11_ASSOCIATE command for the 
libertas' firmware wants the AP's BSSID to connect to. For now, 
I do this:

	if (sme->bssid) {
		bss = cfg80211_get_bss(wiphy, sme->channel, sme->bssid,
			sme->ssid, sme->ssid_len,
			WLAN_CAPABILITY_ESS, WLAN_CAPABILITY_ESS);
	} else {
		ret = -ENOTSUPP;
		goto done;
	}

This makes the "iw connect" command only work if an "iw scan" did 
just take place and I provide an BSS on the command line. 

So maybe net/wireless/sme.c should be generalized ?



BSSID for .deauth/.disassoc vs. .disconnect
-------------------------------------------
Both the .deauth and .disassoc get the cfg80211_bss entry to 
deauth / disassociate against.

.disconnect doesn't get this.

But I need the BSSID for the CMD_802_11_DISASSOCIATE command, so 
I need to store the BSSID locally in priv->XXX. But I'm quite 
sure that cfg80211 already knows to which bssid I'm connected 
(see "iw xxx link"), so it's not nice that I need to store this 
twice.

-- 
http://www.holgerschurig.de

             reply	other threads:[~2009-10-14  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14  9:36 Holger Schurig [this message]
2009-10-14 13:41 ` cfg80211 question: impedance mismatch of .connect versus .assoc Johannes Berg
2009-10-14 14:26   ` Holger Schurig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910141136.03288.hs4233@mail.mn-solutions.de \
    --to=hs4233@mail.mn-solutions.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox