* Re: [PATCH] wl1251: add support for PG11 chips. [not found] <01c201ca4d9c$c2c44500$484ccf00$@Willis@Distant-earth.com> @ 2009-10-16 7:19 ` Kalle Valo 2009-10-16 8:37 ` Kalle Valo 0 siblings, 1 reply; 3+ messages in thread From: Kalle Valo @ 2009-10-16 7:19 UTC (permalink / raw) To: John Willis; +Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com John Willis <John.Willis@Distant-earth.com> writes: > From: David-John Willis <John.Willis@Distant-earth.com> > > This simple patch adds support for the PG11 variant of the WL1251 chip as > used on the OpenPandora OMAP3 device. > > Signed-off-by: David-John Willis <John.Willis@Distant-earth.com> Thanks for the patch. And excellent news that it's working on your device. Minor comment: > --- a/drivers/net/wireless/wl12xx/wl1251_main.c > +++ b/drivers/net/wireless/wl12xx/wl1251_main.c > @@ -185,6 +185,9 @@ static int wl1251_chip_wakeup(struct wl1251 *wl) > break; > case CHIP_ID_1251_PG10: > case CHIP_ID_1251_PG11: > + wl1251_debug(DEBUG_BOOT, "chip id 0x%x (1251 PG11)", > + wl->chip_id); > + break; > default: > wl1251_error("unsupported chip id: 0x%x", wl->chip_id); > ret = -ENODEV; This patch also enables PG10 support, but as that hardware revision is untested I think it's better not to enable it. I'll edit the patch a bit regarding this and then send it to John. -- Kalle Valo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wl1251: add support for PG11 chips. 2009-10-16 7:19 ` [PATCH] wl1251: add support for PG11 chips Kalle Valo @ 2009-10-16 8:37 ` Kalle Valo 2009-10-16 14:05 ` John W. Linville 0 siblings, 1 reply; 3+ messages in thread From: Kalle Valo @ 2009-10-16 8:37 UTC (permalink / raw) To: John Willis; +Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com Kalle Valo <kalle.valo@iki.fi> writes: > John Willis <John.Willis@Distant-earth.com> writes: > >> From: David-John Willis <John.Willis@Distant-earth.com> >> >> This simple patch adds support for the PG11 variant of the WL1251 chip as >> used on the OpenPandora OMAP3 device. >> >> Signed-off-by: David-John Willis <John.Willis@Distant-earth.com> [...] > This patch also enables PG10 support, but as that hardware revision is > untested I think it's better not to enable it. I'll edit the patch a bit > regarding this and then send it to John. Oh, I noticed that Linville had already applied your patch. I'll send a patch on top of this to fix the issue. Linville, is this ok for you? Too many Johns here :) -- Kalle Valo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wl1251: add support for PG11 chips. 2009-10-16 8:37 ` Kalle Valo @ 2009-10-16 14:05 ` John W. Linville 0 siblings, 0 replies; 3+ messages in thread From: John W. Linville @ 2009-10-16 14:05 UTC (permalink / raw) To: Kalle Valo; +Cc: John Willis, linux-wireless@vger.kernel.org On Fri, Oct 16, 2009 at 11:37:53AM +0300, Kalle Valo wrote: > Kalle Valo <kalle.valo@iki.fi> writes: > > > John Willis <John.Willis@Distant-earth.com> writes: > > > >> From: David-John Willis <John.Willis@Distant-earth.com> > >> > >> This simple patch adds support for the PG11 variant of the WL1251 chip as > >> used on the OpenPandora OMAP3 device. > >> > >> Signed-off-by: David-John Willis <John.Willis@Distant-earth.com> > > [...] > > > This patch also enables PG10 support, but as that hardware revision is > > untested I think it's better not to enable it. I'll edit the patch a bit > > regarding this and then send it to John. > > Oh, I noticed that Linville had already applied your patch. I'll send > a patch on top of this to fix the issue. > > Linville, is this ok for you? > > Too many Johns here :) Either way is fine -- it hasn't gone to Dave, so I can sort it out... John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-16 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <01c201ca4d9c$c2c44500$484ccf00$@Willis@Distant-earth.com>
2009-10-16 7:19 ` [PATCH] wl1251: add support for PG11 chips Kalle Valo
2009-10-16 8:37 ` Kalle Valo
2009-10-16 14:05 ` John W. Linville
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).