Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

[Kalle Valo]

Greg KH <greg@kroah.com> writes:

> On Wed, Oct 14, 2009 at 11:03:45PM -0400, Javier Martinez Canillas wrote:
>> I got the following compile error with today linux-next tree.
>> 
>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_reset’:
>> drivers/staging/stlc45xx/stlc45xx.c:1061: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_interrupt’:
>> drivers/staging/stlc45xx/stlc45xx.c:1492: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_wq_tx’:
>> drivers/staging/stlc45xx/stlc45xx.c:1571: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_op_tx’:
>> drivers/staging/stlc45xx/stlc45xx.c:2135: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>> drivers/staging/stlc45xx/stlc45xx.c: At top level:
>> drivers/staging/stlc45xx/stlc45xx.c:2351: warning: initialization from incompatible pointer type
>> 
>> The driver was trying to access directly to mac80211 workqueue. Use the helper functions instead. 
>> 
>> I think this patch solves the issue. Also fix a compile warning due a change in configure_filter() handler params.
>
> ah, good catch, I had that driver disabled in my builds for some stupid
> reason.  I'll queue this up in my tree.

I think it's better to drop stlc45xx. As I haven't sent any patches for
few months is obvious that I don't have time to work on it anymore. And
p54spi should work now, at least I have seen positive reports on mailing
lists.

Greg, if you want I can send a patch removing stlc45xx.

-- 
Kalle Valo

Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

[Javier Martinez Canillas]

If you agree I could take the task to mantain stlc45xx. I have the
time, the motivation and I think the skills to do it.

At least I could make it compile when the API changes and work on bugs
reported until you are confident that p54spi driver is good enough and
there is no need anymore for stlc45xx.

The only thing I dont have it is the hardware but I think I could get one N800.

Best regards,

-----------------------------------------
Javier Martínez Canillas
+595 981 88 66 58



On Fri, Oct 16, 2009 at 3:13 AM, Kalle Valo <kalle.valo@iki.fi> wrote:
> Greg KH <greg@kroah.com> writes:
>
>> On Wed, Oct 14, 2009 at 11:03:45PM -0400, Javier Martinez Canillas wrote:
>>> I got the following compile error with today linux-next tree.
>>>
>>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_reset’:
>>> drivers/staging/stlc45xx/stlc45xx.c:1061: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_interrupt’:
>>> drivers/staging/stlc45xx/stlc45xx.c:1492: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_wq_tx’:
>>> drivers/staging/stlc45xx/stlc45xx.c:1571: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_op_tx’:
>>> drivers/staging/stlc45xx/stlc45xx.c:2135: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’
>>> drivers/staging/stlc45xx/stlc45xx.c: At top level:
>>> drivers/staging/stlc45xx/stlc45xx.c:2351: warning: initialization from incompatible pointer type
>>>
>>> The driver was trying to access directly to mac80211 workqueue. Use the helper functions instead.
>>>
>>> I think this patch solves the issue. Also fix a compile warning due a change in configure_filter() handler params.
>>
>> ah, good catch, I had that driver disabled in my builds for some stupid
>> reason.  I'll queue this up in my tree.
>
> I think it's better to drop stlc45xx. As I haven't sent any patches for
> few months is obvious that I don't have time to work on it anymore. And
> p54spi should work now, at least I have seen positive reports on mailing
> lists.
>
> Greg, if you want I can send a patch removing stlc45xx.
>
> --
> Kalle Valo
>

Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

[Christian Lamparter]

On Friday 16 October 2009 16:11:22 Javier Martinez Canillas wrote:
> At least I could make it compile when the API changes and work on bugs
> reported until you are confident that p54spi driver is good enough and
> there is no need anymore for stlc45xx.

p54spi IS stlc45xx, but with a different name.

> The only thing I dont have it is the hardware but I think I could get one N800.
N810 has a extra keyboard... So it might be the better choice for
developers.

Regards,
	Chr

Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

[Javier Martinez Canillas]

>> At least I could make it compile when the API changes and work on bugs
>> reported until you are confident that p54spi driver is good enough and
>> there is no need anymore for stlc45xx.
>
> p54spi IS stlc45xx, but with a different name.
>

In that case I guess probably the best option would be to remove
stlc45xx from staging as Kalle sugested. Users should migrate to
p54spi since it is already in /net/wireless/

Best regards

-----------------------------------------
Javier Martínez Canillas
+595 981 88 66 58

Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

[Greg KH]

On Fri, Oct 16, 2009 at 11:59:04AM -0400, Javier Martinez Canillas wrote:
> >> At least I could make it compile when the API changes and work on bugs
> >> reported until you are confident that p54spi driver is good enough and
> >> there is no need anymore for stlc45xx.
> >
> > p54spi IS stlc45xx, but with a different name.
> >
> 
> In that case I guess probably the best option would be to remove
> stlc45xx from staging as Kalle sugested. Users should migrate to
> p54spi since it is already in /net/wireless/

Ah, ok, I'll go delete it.

thanks,

greg k-h

Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

[Kalle Valo]

Javier Martinez Canillas <martinez.javier@gmail.com> writes:

>>> At least I could make it compile when the API changes and work on bugs
>>> reported until you are confident that p54spi driver is good enough and
>>> there is no need anymore for stlc45xx.
>>
>> p54spi IS stlc45xx, but with a different name.
>
> In that case I guess probably the best option would be to remove
> stlc45xx from staging as Kalle sugested. Users should migrate to
> p54spi since it is already in /net/wireless/

Yes, p54spi is the future. If you have spare time, better to work on
p54spi instead of stlc45xx.

-- 
Kalle Valo

Re: [PATCH 1/1] staging/stlc45xx: Fix compile error

[Greg KH]

On Fri, Oct 16, 2009 at 10:11:22AM -0400, Javier Martinez Canillas wrote:
> If you agree I could take the task to mantain stlc45xx. I have the
> time, the motivation and I think the skills to do it.
> 
> At least I could make it compile when the API changes and work on bugs
> reported until you are confident that p54spi driver is good enough and
> there is no need anymore for stlc45xx.

Great, care to send me a patch adding a TODO file for this driver so
that we can keep the info straight?

thanks,

greg k-h