From: Randy Dunlap <rdunlap@xenotime.net>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: "linux-wireless" <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
Dan Williams <dcbw@redhat.com>
Subject: Re: [PATCH, v2] libertas: move SIOCGIWAP calls to wext.c
Date: Tue, 20 Oct 2009 08:53:22 -0700 [thread overview]
Message-ID: <20091020085322.4df7773f.rdunlap@xenotime.net> (raw)
In-Reply-To: <200910201439.31384.hs4233@mail.mn-solutions.de>
On Tue, 20 Oct 2009 14:39:31 +0200 Holger Schurig wrote:
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
>
> ---
> v1: Less and less files now depend on WEXT :-)
> v2: fix compilation issue
You should say what compilation issue it fixes.
> --- linux-wl.orig/drivers/net/wireless/libertas/cmdresp.c
> +++ linux-wl/drivers/net/wireless/libertas/cmdresp.c
> @@ -27,23 +27,18 @@
> */
> void lbs_mac_event_disconnected(struct lbs_private *priv)
> {
> - union iwreq_data wrqu;
> -
> if (priv->connect_status != LBS_CONNECTED)
> return;
>
> lbs_deb_enter(LBS_DEB_ASSOC);
>
> - memset(wrqu.ap_addr.sa_data, 0x00, ETH_ALEN);
> - wrqu.ap_addr.sa_family = ARPHRD_ETHER;
>
> /*
> * Cisco AP sends EAP failure and de-auth in less than 0.5 ms.
> * It causes problem in the Supplicant
> */
> -
> msleep_interruptible(1000);
> - wireless_send_event(priv->dev, SIOCGIWAP, &wrqu, NULL);
> + lbs_send_disconnect_notification(priv);
>
> /* report disconnect to upper layer */
> netif_stop_queue(priv->dev);
> --- linux-wl.orig/drivers/net/wireless/libertas/main.c
> +++ linux-wl/drivers/net/wireless/libertas/main.c
> @@ -1227,7 +1227,6 @@
> void lbs_remove_card(struct lbs_private *priv)
> {
> struct net_device *dev = priv->dev;
> - union iwreq_data wrqu;
>
> lbs_deb_enter(LBS_DEB_MAIN);
>
> @@ -1252,9 +1251,7 @@
> lbs_ps_wakeup(priv, CMD_OPTION_WAITFORRSP);
> }
>
> - memset(wrqu.ap_addr.sa_data, 0xaa, ETH_ALEN);
> - wrqu.ap_addr.sa_family = ARPHRD_ETHER;
> - wireless_send_event(priv->dev, SIOCGIWAP, &wrqu, NULL);
> + lbs_send_disconnect_notification(priv);
>
> if (priv->is_deep_sleep) {
> priv->is_deep_sleep = 0;
> --- linux-wl.orig/drivers/net/wireless/libertas/wext.c
> +++ linux-wl/drivers/net/wireless/libertas/wext.c
> @@ -45,6 +45,15 @@
> priv->pending_assoc_req = NULL;
> }
>
> +void lbs_send_disconnect_notification(struct lbs_private *priv)
> +{
> + union iwreq_data wrqu;
> +
> + memset(wrqu.ap_addr.sa_data, 0x00, ETH_ALEN);
> + wrqu.ap_addr.sa_family = ARPHRD_ETHER;
> + wireless_send_event(priv->dev, SIOCGIWAP, &wrqu, NULL);
> +}
> +
> void lbs_send_iwevcustom_event(struct lbs_private *priv, s8 *str)
> {
> union iwreq_data iwrq;
> --- linux-wl.orig/drivers/net/wireless/libertas/wext.h
> +++ linux-wl/drivers/net/wireless/libertas/wext.h
> @@ -4,6 +4,7 @@
> #ifndef _LBS_WEXT_H_
> #define _LBS_WEXT_H_
>
> +void lbs_send_disconnect_notification(struct lbs_private *priv);
> void lbs_send_iwevcustom_event(struct lbs_private *priv, s8 *str);
>
> extern struct iw_handler_def lbs_handler_def;
>
>
> --
---
~Randy
prev parent reply other threads:[~2009-10-20 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 13:04 [PATCH] libertas: move SIOCGIWAP calls to wext.c Holger Schurig
2009-10-20 12:39 ` [PATCH, v2] " Holger Schurig
2009-10-20 15:53 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020085322.4df7773f.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox