From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: "linux-wireless" <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
Dan Williams <dcbw@redhat.com>
Subject: Re: [PATCH] libertas: move mic failure event to wext.c
Date: Thu, 22 Oct 2009 09:21:35 +0200 [thread overview]
Message-ID: <200910220921.35223.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <20091020085431.e26cce67.rdunlap@xenotime.net>
> argh. urgh. This file (or files) need to lose this
> non-kernel-doc function notation. Please.
Two things here:
* it's a copy and paste patch, so we move things just to another
place. This makes the cfg80211-patch less intrusive and also
makes the driver way smaller, once we don't compile WEXT in or
get rid of WEXT altogether. Normally for copy-and-paste patches
you shouldn't change other things.
* When I started with libertas, those comments where mostly
useful for me. I didn't care for /** or @, as I just read the
text. For me, those extra decorations have a less
negative "touch". The "positive" effect of having comments at
all did by far outweight the formatting.
For new code, I use a "normal" comment style, for example see
http://marc.info/?l=linux-wireless&m=125569942616188&w=2
So, if the comment style really annoys you, you could submit a
comment-reformat-patch.
--
http://www.holgerschurig.de
prev parent reply other threads:[~2009-10-22 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 13:05 [PATCH] libertas: move mic failure event to wext.c Holger Schurig
2009-10-20 15:54 ` Randy Dunlap
2009-10-22 7:21 ` Holger Schurig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910220921.35223.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox