Questions about cfg80211's cfg80211_connect_params->crypto settings

[Holger Schurig <hs4233@mail.mn-solutions.de>]

Hi,

I'm a but confused about what fields in "struct 
cfg80211_connect_params" (now abbreviated as sme->)
are relevant for me.


sme->private
------------
Right now, my lbs_cfg_connect() code just tests 
sme->crypto.cipher_group. It doesn't check or use sme->privacy.

 and sme-> crypto.wpa_versions like they are redundant. Is this 
correct?

Empirical it migth be correct, because I can successfully connect 
to APs, but if "privacy" is redundant, should I prepare a patch 
to get rid of it?

What is this?  And how should my driver react to it's settings?



sme->crypto.wpa_versions
------------------------
Again I seems to be ok to ignore this variable and just check 
sme->crypto.cipher_group. In practice this seems to work, but is 
it correct?

What is this, what is the intented use of it?  May I prepare a 
patch to get rid of it?



sme->crypto.n_ciphers_pairwise, sme->crypto.ciphers_pairwise
------------------------------------------------------------
The same for sme->crypto.n_ciphers_pairwise. It is always 0 zero 
for the WEP case and always 1 for the WPA/WPA2 case, so isn't it 
redundant either?  lbs_cfg_connect() ignores this, maybe it's 
not needed at .connect() time anyway?

But what is it really, what is the intended use?



sme->crypto.n_akm_suites, sme->crypto.akm_suites
------------------------------------------------
In cfg80211.h, the kdoc help text for sme->crypo.akm_suites is 
just "AKM suites" or "number of AKM suites", which keeps me as 
confused as before.

What is this?  And how should my driver react to it's settings?


-- 
http://www.holgerschurig.de