From: Bob Copeland <me@bobcopeland.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: dsrbecky@gmail.com, Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-wireless@vger.kernel.org
Subject: Re: ath5k phy0: no further txbuf available, dropping packet
Date: Tue, 27 Oct 2009 06:09:26 -0400 [thread overview]
Message-ID: <20091027100926.GA13391@hash.localnet> (raw)
In-Reply-To: <200910262230.57957.mb@bu3sch.de>
On Mon, Oct 26, 2009 at 10:30:55PM +0100, Michael Buesch wrote:
> /* No frame has been send or error */
> if (unlikely(!(tx_status->tx_status_1 & AR5K_DESC_TX_STATUS1_DONE)))
> return -EINPROGRESS;
> ...
> }
> Notice the comment and how it says "or error".
Hmm, that does sound problematic. But looking at the various bitfields:
#define AR5K_DESC_TX_STATUS1_DONE 0x00000001
#define AR5K_DESC_TX_STATUS1_SEQ_NUM 0x00001ffe
#define AR5K_DESC_TX_STATUS1_ACK_SIG_STRENGTH 0x001fe000
#define AR5K_DESC_TX_STATUS1_FINAL_TS_INDEX 0x00600000
#define AR5K_DESC_TX_STATUS1_COMP_SUCCESS 0x00800000
#define AR5K_DESC_TX_STATUS1_XMIT_ANTENNA 0x01000000
I would be led to believe that 'done' means 'completed or error' and
the comment is similarly ambiguous. The status0 word contains things
like 'really did succeed, number of retries, timestamp' etc.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-10-27 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 20:52 ath5k phy0: no further txbuf available, dropping packet David Srbecky
2009-10-26 21:30 ` Michael Buesch
2009-10-26 21:34 ` Michael Buesch
2009-10-27 10:09 ` Bob Copeland [this message]
2009-10-27 10:29 ` Michael Buesch
2009-11-08 18:12 ` David Srbecky
2009-11-09 15:55 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091027100926.GA13391@hash.localnet \
--to=me@bobcopeland.com \
--cc=dsrbecky@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mb@bu3sch.de \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).