From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: make CALL_TXH a statement
Date: Fri, 30 Oct 2009 15:11:26 -0400 [thread overview]
Message-ID: <20091030191126.GC2586@tuxdriver.com> (raw)
In-Reply-To: <1256802228.3865.55.camel@johannes.local>
On Thu, Oct 29, 2009 at 08:43:48AM +0100, Johannes Berg wrote:
> The multi-line code in this macro wasn't wrapped
> in do {} while (0) so we cannot use it in an if()
> branch safely in the future -- fix that.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
do {...} while (0) won't work for that either, right? You need
({...}) instead if you want to return a value. Is that what you want?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-10-30 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 7:43 [PATCH] mac80211: make CALL_TXH a statement Johannes Berg
2009-10-30 19:11 ` John W. Linville [this message]
2009-10-30 20:43 ` Johannes Berg
2009-10-30 20:45 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030191126.GC2586@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).