linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Nikolai ZHUBR <zhubr@mail.ru>, linux-wireless@vger.kernel.org
Subject: Re: ieee80211_tx_status: headroom too small
Date: Sat, 31 Oct 2009 09:51:29 +0100	[thread overview]
Message-ID: <200910310951.30016.IvDoorn@gmail.com> (raw)
In-Reply-To: <1256967967.3555.71.camel@johannes.local>

On Saturday 31 October 2009, Johannes Berg wrote:
> On Sat, 2009-10-31 at 00:56 +0300, Nikolai ZHUBR wrote:
> > Friday, October 30, 2009, 11:59:01 PM, Johannes Berg wrote:
> > >>
> > >> ieee80211_tx_status: headroom too small
> > 
> > > What driver are you using?
> > 
> > Ah, sorry, forgot to mention. It is rt61pci (RaLink mini-PCI card)
> 
> Ok. I looked at the problem and it's a very odd problem -- mac80211
> should always reserve enough headroom in buffers it passes to the
> driver. Does rt61pci somehow realloc frames?

It does use skb_push. but will/should always stay within the limits
of rt2x00dev->hw->extra_tx_headroom. Although I just realize there
might be a situation where it needs to align the frame to a 4-byte boundary,
it could exceed that amount. :(

Ivo

  reply	other threads:[~2009-10-31  8:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-30 20:00 ieee80211_tx_status: headroom too small Nikolai ZHUBR
2009-10-30 20:03 ` Luis R. Rodriguez
2009-10-30 20:49   ` Re[2]: " Nikolai ZHUBR
2009-10-30 20:59 ` Johannes Berg
2009-10-30 21:56   ` Re[2]: " Nikolai ZHUBR
2009-10-31  5:46     ` Johannes Berg
2009-10-31  8:51       ` Ivo van Doorn [this message]
2009-10-31  8:56         ` Johannes Berg
2009-10-31  8:59           ` Ivo van Doorn
2009-10-31  9:25             ` Johannes Berg
2009-10-31  9:30               ` Ivo van Doorn
2009-10-31  9:34                 ` Johannes Berg
2009-10-31  9:44                   ` Ivo van Doorn
2009-10-31 10:03                     ` Johannes Berg
2009-10-31 10:17                       ` Ivo van Doorn
2009-10-31 10:23                         ` Johannes Berg
2009-10-31 10:33                           ` Ivo van Doorn
2009-10-31 14:24                   ` Re[2]: " Nikolai ZHUBR
2009-10-31 15:35                     ` Johannes Berg
2009-10-31 17:42                       ` Re[4]: " Nikolai ZHUBR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910310951.30016.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zhubr@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).