From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Nikolai ZHUBR <zhubr@mail.ru>, linux-wireless@vger.kernel.org
Subject: Re: ieee80211_tx_status: headroom too small
Date: Sat, 31 Oct 2009 10:44:45 +0100 [thread overview]
Message-ID: <200910311044.45687.IvDoorn@gmail.com> (raw)
In-Reply-To: <1256981677.3555.94.camel@johannes.local>
On Saturday 31 October 2009, Johannes Berg wrote:
> On Sat, 2009-10-31 at 10:30 +0100, Ivo van Doorn wrote:
>
> > > > 4 actually, wasn't there some cases where the header could have an odd
> > > > number of bytes and would require 3 bytes for alignment?
> > >
> > > Hm, is there? I thought they changed the 11s draft to no longer have
> > > that.
> >
> > Well 2 is fine in that case, (I was basing my comment on something said on this mailinglist
> > a long time ago). :)
>
> However, it really all depends on the hardware too ... Maybe we should
> put more of the logic into drivers, and have mac80211 only export its
> required headroom?
>
> Or maybe we should just not bother with having drivers do the alignment
> any more -- mac80211 does that now and it only does it if necessary
> (i.e. not on powerpc/x86)
I think you mean the RX alignment, while I am talking about the TX alignment.
Beacons and some othe frames must be 4-byte alignment because the wireleless
hardware requires it.
Ivo
next prev parent reply other threads:[~2009-10-31 9:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 20:00 ieee80211_tx_status: headroom too small Nikolai ZHUBR
2009-10-30 20:03 ` Luis R. Rodriguez
2009-10-30 20:49 ` Re[2]: " Nikolai ZHUBR
2009-10-30 20:59 ` Johannes Berg
2009-10-30 21:56 ` Re[2]: " Nikolai ZHUBR
2009-10-31 5:46 ` Johannes Berg
2009-10-31 8:51 ` Ivo van Doorn
2009-10-31 8:56 ` Johannes Berg
2009-10-31 8:59 ` Ivo van Doorn
2009-10-31 9:25 ` Johannes Berg
2009-10-31 9:30 ` Ivo van Doorn
2009-10-31 9:34 ` Johannes Berg
2009-10-31 9:44 ` Ivo van Doorn [this message]
2009-10-31 10:03 ` Johannes Berg
2009-10-31 10:17 ` Ivo van Doorn
2009-10-31 10:23 ` Johannes Berg
2009-10-31 10:33 ` Ivo van Doorn
2009-10-31 14:24 ` Re[2]: " Nikolai ZHUBR
2009-10-31 15:35 ` Johannes Berg
2009-10-31 17:42 ` Re[4]: " Nikolai ZHUBR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910311044.45687.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=zhubr@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).