From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ew0-f207.google.com ([209.85.219.207]:53580 "EHLO mail-ew0-f207.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758380AbZKESlm (ORCPT ); Thu, 5 Nov 2009 13:41:42 -0500 From: Ivo van Doorn To: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 05/41] rt2800pci: fix comment about register access Date: Thu, 5 Nov 2009 19:41:43 +0100 Cc: linux-wireless@vger.kernel.org, Gertjan van Wingerde , linux-kernel@vger.kernel.org, "John W. Linville" References: <20091104173151.28463.68742.sendpatchset@localhost.localdomain> <20091104173232.28463.47998.sendpatchset@localhost.localdomain> In-Reply-To: <20091104173232.28463.47998.sendpatchset@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Message-Id: <200911051941.44268.IvDoorn@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] rt2800pci: fix comment about register access > > Registers used for indirect BBP and RF registers access are > respectively BBPCSR and RFCSR, also make it clear that all CSR > registers access goes through rt2x00pci_register_[read,write]() > methods. > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Ivo van Doorn > --- > drivers/net/wireless/rt2x00/rt2800pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Index: b/drivers/net/wireless/rt2x00/rt2800pci.c > =================================================================== > --- a/drivers/net/wireless/rt2x00/rt2800pci.c > +++ b/drivers/net/wireless/rt2x00/rt2800pci.c > @@ -56,8 +56,10 @@ MODULE_PARM_DESC(nohwcrypt, "Disable har > > /* > * Register access. > + * All access to the CSR registers will go through the methods > + * rt2x00pci_register_read and rt2x00pci_register_write. > * BBP and RF register require indirect register access, > - * and use the CSR registers PHY_CSR3 and PHY_CSR4 to achieve this. > + * and use the CSR registers BBPCSR and RFCSR to achieve this. > * These indirect registers work with busy bits, > * and we will try maximal REGISTER_BUSY_COUNT times to access > * the register while taking a REGISTER_BUSY_DELAY us delay >