* Re: [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver)
2009-11-06 13:00 [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver) Carlo Parata
@ 2009-11-06 15:16 ` Bob Copeland
2009-11-06 15:23 ` Larry Finger
2009-11-06 15:54 ` Carlo Parata
2009-11-06 16:09 ` John W. Linville
2 siblings, 1 reply; 9+ messages in thread
From: Bob Copeland @ 2009-11-06 15:16 UTC (permalink / raw)
To: Carlo Parata; +Cc: linux-wireless
On Fri, Nov 6, 2009 at 8:00 AM, Carlo Parata <carlo_parata@hotmail.com> wrote:
> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
> compatible devices in ath5k driver now includes the hardware present in this
> computer, as well as the led pin and polarity.
>
> --- ../led.c 2009-11-06 06:16:39.000000000 +0100
> +++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
> @@ -73,6 +73,8 @@
> { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> /* IBM-specific AR5212 (all others) */
> { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
> + /* Acer Aspire One D250 AR5007EG */
> + { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
No, this should be based on the subdevice instead
(there are lots of ath:001c with different LED settings).
Also, please add your email to the appropriate stanza.
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver)
2009-11-06 15:16 ` Bob Copeland
@ 2009-11-06 15:23 ` Larry Finger
0 siblings, 0 replies; 9+ messages in thread
From: Larry Finger @ 2009-11-06 15:23 UTC (permalink / raw)
To: Bob Copeland; +Cc: Carlo Parata, linux-wireless
On 11/06/2009 09:16 AM, Bob Copeland wrote:
> On Fri, Nov 6, 2009 at 8:00 AM, Carlo Parata <carlo_parata@hotmail.com> wrote:
>> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
>> compatible devices in ath5k driver now includes the hardware present in this
>> computer, as well as the led pin and polarity.
>>
>> --- ../led.c 2009-11-06 06:16:39.000000000 +0100
>> +++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
>> @@ -73,6 +73,8 @@
>> { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
>> /* IBM-specific AR5212 (all others) */
>> { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
>> + /* Acer Aspire One D250 AR5007EG */
>> + { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
>
> No, this should be based on the subdevice instead
> (there are lots of ath:001c with different LED settings).
>
> Also, please add your email to the appropriate stanza.
It is more than just your E-mail address. Please see
Documents/SubmittingPatches.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver)
2009-11-06 13:00 [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver) Carlo Parata
2009-11-06 15:16 ` Bob Copeland
@ 2009-11-06 15:54 ` Carlo Parata
2009-11-06 16:01 ` Holger Schurig
2009-11-06 16:09 ` John W. Linville
2 siblings, 1 reply; 9+ messages in thread
From: Carlo Parata @ 2009-11-06 15:54 UTC (permalink / raw)
To: linux-wireless
Carlo Parata <carlo_parata@...> writes:
>
> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
> compatible devices in ath5k driver now includes the hardware present in this
> computer, as well as the led pin and polarity.
>
> --- ../led.c 2009-11-06 06:16:39.000000000 +0100
> +++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
> @@ -73,6 +73,8 @@
> { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> /* IBM-specific AR5212 (all others) */
> { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
> + /* Acer Aspire One D250 AR5007EG */
> + { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
> { }
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Excuse me but it is the first post for me in this mailing list.
How can I find out the subdevice of my wireless card?
The device specifications shown by Windows XP are:
PCI\VEN_168C&DEV_001C&SUBSYS_E00D105B&REV_01\4&192AC53F&0&00E0
Thanks
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver)
2009-11-06 13:00 [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver) Carlo Parata
2009-11-06 15:16 ` Bob Copeland
2009-11-06 15:54 ` Carlo Parata
@ 2009-11-06 16:09 ` John W. Linville
2009-11-06 16:21 ` Bob Copeland
2 siblings, 1 reply; 9+ messages in thread
From: John W. Linville @ 2009-11-06 16:09 UTC (permalink / raw)
To: Carlo Parata; +Cc: linux-wireless, me
On Fri, Nov 06, 2009 at 01:00:02PM +0000, Carlo Parata wrote:
> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
> compatible devices in ath5k driver now includes the hardware present in this
> computer, as well as the led pin and polarity.
>
> --- ../led.c 2009-11-06 06:16:39.000000000 +0100
> +++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
> @@ -73,6 +73,8 @@
> { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> /* IBM-specific AR5212 (all others) */
> { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
> + /* Acer Aspire One D250 AR5007EG */
> + { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
> { }
> };
FWIW, a similar patch earlier this week drew the following from Bob Copeand:
"... but can you by chance put a contact address in the comment? I've been
collecting them in case we one day figure out a better way to do this so it's
easy to find the people to retest."
Would you mind complying with his request? Or have I mistakend his applicability?
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] Wifi led does not work on Acer Aspire One D250 (ath5k driver)
2009-11-06 16:09 ` John W. Linville
@ 2009-11-06 16:21 ` Bob Copeland
2009-11-06 16:46 ` Carlo Parata
0 siblings, 1 reply; 9+ messages in thread
From: Bob Copeland @ 2009-11-06 16:21 UTC (permalink / raw)
To: John W. Linville; +Cc: Carlo Parata, linux-wireless
On Fri, Nov 6, 2009 at 11:09 AM, John W. Linville
<linville@tuxdriver.com> wrote:
> "... but can you by chance put a contact address in the comment? I've been
> collecting them in case we one day figure out a better way to do this so it's
> easy to find the people to retest."
>
> Would you mind complying with his request? Or have I mistakend his applicability?
It's still applicable in the general case, but I think the new patch
is for the same HW as the earlier one posted (Carlo can confirm)
so we should be good already.
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 9+ messages in thread