* [PATCH] rt2x00: fix build of rt2800lib
@ 2009-11-08 12:07 Hauke Mehrtens
2009-11-08 12:25 ` Bartlomiej Zolnierkiewicz
2009-11-08 12:37 ` Ivo van Doorn
0 siblings, 2 replies; 6+ messages in thread
From: Hauke Mehrtens @ 2009-11-08 12:07 UTC (permalink / raw)
To: IvDoorn, gwingerde; +Cc: linux-wireless, users, bzolnier, Hauke Mehrtens
rt2x00usb.h uses lots of definitions from linux/usb.h.
---
drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 5c7d74a..b601a1a 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -29,6 +29,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
+#include <linux/usb.h>
#include "rt2x00.h"
#ifdef CONFIG_RT2800USB
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] rt2x00: fix build of rt2800lib
2009-11-08 12:07 [PATCH] rt2x00: fix build of rt2800lib Hauke Mehrtens
@ 2009-11-08 12:25 ` Bartlomiej Zolnierkiewicz
2009-11-08 13:27 ` Hauke Mehrtens
2009-11-08 12:37 ` Ivo van Doorn
1 sibling, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-11-08 12:25 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: IvDoorn, gwingerde, linux-wireless, users
Hi,
Could you please tell us more about build problems you have
encountered and which kernel tree this fix is for?
Thanks.
On Sunday 08 November 2009 13:07:01 Hauke Mehrtens wrote:
> rt2x00usb.h uses lots of definitions from linux/usb.h.
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 5c7d74a..b601a1a 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -29,6 +29,7 @@
>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/usb.h>
>
> #include "rt2x00.h"
> #ifdef CONFIG_RT2800USB
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rt2x00: fix build of rt2800lib
2009-11-08 12:25 ` Bartlomiej Zolnierkiewicz
@ 2009-11-08 13:27 ` Hauke Mehrtens
2009-11-08 17:31 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Hauke Mehrtens @ 2009-11-08 13:27 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: IvDoorn, gwingerde, linux-wireless, users
[-- Attachment #1: Type: text/plain, Size: 5650 bytes --]
Hi,
I am building recent wireless-testing. Without my patch I get the
following error while compiling it with CONFIG_RT2800USB=y with
CONFIG_RT2800USB=m it compiles fine without any modifications. Looks
like there is an other problem and my patch does not fix the real problem.
Hauke
CC drivers/net/wireless/rt2x00/rt2800lib.o
In file included from drivers/net/wireless/rt2x00/rt2800lib.c:35:
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_vendor_request_sw':
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: (Each undeclared
identifier is reported only once
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: for each function it
appears in.)
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_eeprom_read':
drivers/net/wireless/rt2x00/rt2x00usb.h:223: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:223: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:223: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_read':
drivers/net/wireless/rt2x00/rt2x00usb.h:243: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:243: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:243: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_read_lock':
drivers/net/wireless/rt2x00/rt2x00usb.h:263: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:263: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:263: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_multiread':
drivers/net/wireless/rt2x00/rt2x00usb.h:283: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:283: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:283: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_write':
drivers/net/wireless/rt2x00/rt2x00usb.h:303: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:303: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:303: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_write_lock':
drivers/net/wireless/rt2x00/rt2x00usb.h:322: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:322: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:322: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_multiwrite':
drivers/net/wireless/rt2x00/rt2x00usb.h:342: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:342: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:342: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: At top level:
drivers/net/wireless/rt2x00/rt2x00usb.h:439: warning: 'struct
usb_interface' declared inside parameter list
drivers/net/wireless/rt2x00/rt2x00usb.h:439: warning: its scope is only
this definition or declaration, which is probably not what you want
drivers/net/wireless/rt2x00/rt2x00usb.h:440: warning: 'struct
usb_interface' declared inside parameter list
drivers/net/wireless/rt2x00/rt2x00usb.h:442: warning: 'struct
usb_interface' declared inside parameter list
drivers/net/wireless/rt2x00/rt2x00usb.h:443: warning: 'struct
usb_interface' declared inside parameter list
make[4]: *** [drivers/net/wireless/rt2x00/rt2800lib.o] Error 1
make[3]: *** [drivers/net/wireless/rt2x00] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Fehler 2
Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Could you please tell us more about build problems you have
> encountered and which kernel tree this fix is for?
>
> Thanks.
>
> On Sunday 08 November 2009 13:07:01 Hauke Mehrtens wrote:
>> rt2x00usb.h uses lots of definitions from linux/usb.h.
>> ---
>> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index 5c7d74a..b601a1a 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -29,6 +29,7 @@
>>
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> +#include <linux/usb.h>
>>
>> #include "rt2x00.h"
>> #ifdef CONFIG_RT2800USB
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 898 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rt2x00: fix build of rt2800lib
2009-11-08 13:27 ` Hauke Mehrtens
@ 2009-11-08 17:31 ` Bartlomiej Zolnierkiewicz
2009-11-09 22:24 ` Gertjan van Wingerde
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-11-08 17:31 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: IvDoorn, gwingerde, linux-wireless, users
On Sunday 08 November 2009 14:27:38 Hauke Mehrtens wrote:
> Hi,
>
> I am building recent wireless-testing. Without my patch I get the
> following error while compiling it with CONFIG_RT2800USB=y with
> CONFIG_RT2800USB=m it compiles fine without any modifications. Looks
> like there is an other problem and my patch does not fix the real problem.
I've reproduced it here and your patch is fine but it would be better
if rt2x00usb.h would include <linux/usb.h> itself instead of depending on
its users (device drivers) but I'll leave this decision up to Ivo/Gartjan.
I've fixed the issue in the patch introducing the problem ("rt2800: add
rt2800lib (part three)") to preserve bisectability of rt2800usb driver.
Thanks.
--
Bartlomiej Zolnierkiewicz
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rt2x00: fix build of rt2800lib
2009-11-08 17:31 ` Bartlomiej Zolnierkiewicz
@ 2009-11-09 22:24 ` Gertjan van Wingerde
0 siblings, 0 replies; 6+ messages in thread
From: Gertjan van Wingerde @ 2009-11-09 22:24 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Hauke Mehrtens, IvDoorn, linux-wireless, users
On 11/08/09 18:31, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 08 November 2009 14:27:38 Hauke Mehrtens wrote:
>> Hi,
>>
>> I am building recent wireless-testing. Without my patch I get the
>> following error while compiling it with CONFIG_RT2800USB=y with
>> CONFIG_RT2800USB=m it compiles fine without any modifications. Looks
>> like there is an other problem and my patch does not fix the real problem.
>
> I've reproduced it here and your patch is fine but it would be better
> if rt2x00usb.h would include <linux/usb.h> itself instead of depending on
> its users (device drivers) but I'll leave this decision up to Ivo/Gartjan.
>
> I've fixed the issue in the patch introducing the problem ("rt2800: add
> rt2800lib (part three)") to preserve bisectability of rt2800usb driver.
>
Actually, including <linux/usb.h> from rt2x00usb.h would be more appropriate.
I'll send a patch for it.
---
Gertjan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rt2x00: fix build of rt2800lib
2009-11-08 12:07 [PATCH] rt2x00: fix build of rt2800lib Hauke Mehrtens
2009-11-08 12:25 ` Bartlomiej Zolnierkiewicz
@ 2009-11-08 12:37 ` Ivo van Doorn
1 sibling, 0 replies; 6+ messages in thread
From: Ivo van Doorn @ 2009-11-08 12:37 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: gwingerde, linux-wireless, users, bzolnier
On Sunday 08 November 2009, Hauke Mehrtens wrote:
> rt2x00usb.h uses lots of definitions from linux/usb.h.
rt2800lib should not depend on either PCI or USB,
so which defines from usb.h are used in rt2x00lib.c?
Ivo
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 5c7d74a..b601a1a 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -29,6 +29,7 @@
>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/usb.h>
>
> #include "rt2x00.h"
> #ifdef CONFIG_RT2800USB
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-11-09 22:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-08 12:07 [PATCH] rt2x00: fix build of rt2800lib Hauke Mehrtens
2009-11-08 12:25 ` Bartlomiej Zolnierkiewicz
2009-11-08 13:27 ` Hauke Mehrtens
2009-11-08 17:31 ` Bartlomiej Zolnierkiewicz
2009-11-09 22:24 ` Gertjan van Wingerde
2009-11-08 12:37 ` Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).