From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Gertjan van Wingerde <gwingerde@gmail.com>
Subject: Re: [PATCH] rt2500usb: remove dead link tuning code
Date: Sun, 8 Nov 2009 15:12:52 +0100 [thread overview]
Message-ID: <200911081512.52140.bzolnier@gmail.com> (raw)
In-Reply-To: <200911081450.35804.IvDoorn@gmail.com>
On Sunday 08 November 2009 14:50:35 Ivo van Doorn wrote:
> On Sunday 08 November 2009, Bartlomiej Zolnierkiewicz wrote:
> > Link tuning code from the legacy rt2570 driver turned out to be
> > harmful and got disabled by the commit d06193f ("rt2x00: Disable
> > link tuning in rt2500usb") in August 2008.
> >
> > There is no reason to keep this dead code any longer so remove it
> > (it can still be retrieved from the git history if necessary).
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Please keep this code. There is no particular reason to delete it,
> and at the moment I prefer this code to be kept close at hand.
It is trivial to see/retrieve the deleted code using git when there
is a specific need for it.
OTOH having it visible in the current tree distributed to _thousands_
of developers serves as a distraction and waste of people's time..
--
Bartlomiej Zolnierkiewicz
prev parent reply other threads:[~2009-11-08 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 13:43 [PATCH] rt2500usb: remove dead link tuning code Bartlomiej Zolnierkiewicz
2009-11-08 13:49 ` Gertjan van Wingerde
2009-11-08 13:50 ` Ivo van Doorn
2009-11-08 14:12 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911081512.52140.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).