linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rt2x00: Mark rt2800pci as broken.
Date: Sun, 8 Nov 2009 18:20:18 +0100	[thread overview]
Message-ID: <200911081820.18251.bzolnier@gmail.com> (raw)
In-Reply-To: <200911081338.34697.bzolnier@gmail.com>

On Sunday 08 November 2009 13:38:34 Bartlomiej Zolnierkiewicz wrote:

> On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote:
> > The rt2800pci driver is currently only marked as experimental, and only the help text explains that
> > the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot
> > enable this driver without knowing that it is broken.
> > 
> > Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> 
> > @@ -78,9 +78,6 @@ config RT2800PCI
> >  	  This adds support for rt2800 wireless chipset family.
> >  	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
> >  
> > -	  This driver is non-functional at the moment and is intended for
> > -	  developers.
> > -
> >  	  When compiled as a module, this driver will be called "rt2800pci.ko".
> >  
> >  config RT2500USB
> 
> This help text could have stayed, anyway..
> 
> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

It turned out that CONFIG_BROKEN is no longer an user visible option so by
applying this change we would lose the advantage of having the upstream build
testing and early detection of breakages related to upstream API updates.

[ I've just noticed now that rt2800pci was no longer included in the build
  and dropped the patch from rt2800 tree. ]

-- 
Bartlomiej Zolnierkiewicz

  parent reply	other threads:[~2009-11-08 17:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 11:28 [PATCH] rt2x00: Mark rt2800pci as broken Gertjan van Wingerde
2009-11-08 12:37 ` Ivo van Doorn
2009-11-08 12:38 ` Bartlomiej Zolnierkiewicz
2009-11-08 12:50   ` Gertjan van Wingerde
2009-11-08 13:02     ` Bartlomiej Zolnierkiewicz
2009-11-08 17:20   ` Bartlomiej Zolnierkiewicz [this message]
2009-11-08 19:02     ` Gertjan van Wingerde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911081820.18251.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=gwingerde@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).