[PATCH] rt2x00: Mark rt2800pci as broken.

[PATCH] rt2x00: Mark rt2800pci as broken.

[Gertjan van Wingerde]

The rt2800pci driver is currently only marked as experimental, and only the help text explains that
the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot
enable this driver without knowing that it is broken.

Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
---
 drivers/net/wireless/rt2x00/Kconfig |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
index bf60689..b0f4a2f 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -64,8 +64,8 @@ config RT2800PCI_SOC
 	default y
 
 config RT2800PCI
-	tristate "Ralink rt2800 (PCI/PCMCIA) support (VERY EXPERIMENTAL)"
-	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL
+	tristate "Ralink rt2800 (PCI/PCMCIA) support (BROKEN)"
+	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL && BROKEN
 	select RT2800_LIB
 	select RT2X00_LIB_PCI if RT2800PCI_PCI
 	select RT2X00_LIB_SOC if RT2800PCI_SOC
@@ -78,9 +78,6 @@ config RT2800PCI
 	  This adds support for rt2800 wireless chipset family.
 	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
 
-	  This driver is non-functional at the moment and is intended for
-	  developers.
-
 	  When compiled as a module, this driver will be called "rt2800pci.ko".
 
 config RT2500USB
-- 
1.6.5.2

Re: [PATCH] rt2x00: Mark rt2800pci as broken.

[Ivo van Doorn]

On Sunday 08 November 2009, Gertjan van Wingerde wrote:
> The rt2800pci driver is currently only marked as experimental, and only the help text explains that
> the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot
> enable this driver without knowing that it is broken.
> 
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/Kconfig |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
> index bf60689..b0f4a2f 100644
> --- a/drivers/net/wireless/rt2x00/Kconfig
> +++ b/drivers/net/wireless/rt2x00/Kconfig
> @@ -64,8 +64,8 @@ config RT2800PCI_SOC
>  	default y
>  
>  config RT2800PCI
> -	tristate "Ralink rt2800 (PCI/PCMCIA) support (VERY EXPERIMENTAL)"
> -	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL
> +	tristate "Ralink rt2800 (PCI/PCMCIA) support (BROKEN)"
> +	depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL && BROKEN
>  	select RT2800_LIB
>  	select RT2X00_LIB_PCI if RT2800PCI_PCI
>  	select RT2X00_LIB_SOC if RT2800PCI_SOC
> @@ -78,9 +78,6 @@ config RT2800PCI
>  	  This adds support for rt2800 wireless chipset family.
>  	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
>  
> -	  This driver is non-functional at the moment and is intended for
> -	  developers.
> -
>  	  When compiled as a module, this driver will be called "rt2800pci.ko".
>  
>  config RT2500USB

Re: [PATCH] rt2x00: Mark rt2800pci as broken.

[Bartlomiej Zolnierkiewicz]

[ please cc: me on rt2x00 patches if possible, thanks ]

On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote:
> The rt2800pci driver is currently only marked as experimental, and only the help text explains that
> the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot
> enable this driver without knowing that it is broken.
> 
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>

> @@ -78,9 +78,6 @@ config RT2800PCI
>  	  This adds support for rt2800 wireless chipset family.
>  	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
>  
> -	  This driver is non-functional at the moment and is intended for
> -	  developers.
> -
>  	  When compiled as a module, this driver will be called "rt2800pci.ko".
>  
>  config RT2500USB

This help text could have stayed, anyway..

Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

[ This is against rt2800 tree right?  Cause I don't see any of my patches
  in public rt2x00 tree yet. ]

--
Bartlomiej Zolnierkiewicz

Re: [PATCH] rt2x00: Mark rt2800pci as broken.

[Gertjan van Wingerde]

On 11/08/09 13:38, Bartlomiej Zolnierkiewicz wrote:
> 
> [ This is against rt2800 tree right?  Cause I don't see any of my patches
>   in public rt2x00 tree yet. ]
> 

Actually, it is against wireless-testing.

---
Gertjan

Re: [PATCH] rt2x00: Mark rt2800pci as broken.

[Bartlomiej Zolnierkiewicz]

On Sunday 08 November 2009 13:50:05 Gertjan van Wingerde wrote:
> On 11/08/09 13:38, Bartlomiej Zolnierkiewicz wrote:
> > 
> > [ This is against rt2800 tree right?  Cause I don't see any of my patches
> >   in public rt2x00 tree yet. ]
> > 
> 
> Actually, it is against wireless-testing.

Interesting. :)

John, you may want to replace what you have with rt2800-v2.1 branch of
misc.git tree (more ACKs from Ivo and order is optimized a bit based on
feedback from Julian).

-- 
Bartlomiej Zolnierkiewicz

Re: [PATCH] rt2x00: Mark rt2800pci as broken.

[Bartlomiej Zolnierkiewicz]

On Sunday 08 November 2009 13:38:34 Bartlomiej Zolnierkiewicz wrote:

> On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote:
> > The rt2800pci driver is currently only marked as experimental, and only the help text explains that
> > the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot
> > enable this driver without knowing that it is broken.
> > 
> > Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> 
> > @@ -78,9 +78,6 @@ config RT2800PCI
> >  	  This adds support for rt2800 wireless chipset family.
> >  	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
> >  
> > -	  This driver is non-functional at the moment and is intended for
> > -	  developers.
> > -
> >  	  When compiled as a module, this driver will be called "rt2800pci.ko".
> >  
> >  config RT2500USB
> 
> This help text could have stayed, anyway..
> 
> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

It turned out that CONFIG_BROKEN is no longer an user visible option so by
applying this change we would lose the advantage of having the upstream build
testing and early detection of breakages related to upstream API updates.

[ I've just noticed now that rt2800pci was no longer included in the build
  and dropped the patch from rt2800 tree. ]

-- 
Bartlomiej Zolnierkiewicz

Re: [PATCH] rt2x00: Mark rt2800pci as broken.

[Gertjan van Wingerde]

On 11/08/09 18:20, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 08 November 2009 13:38:34 Bartlomiej Zolnierkiewicz wrote:
> 
>> On Sunday 08 November 2009 12:28:54 Gertjan van Wingerde wrote:
>>> The rt2800pci driver is currently only marked as experimental, and only the help text explains that
>>> the driver is basically non-functional. Make the driver depend on CONFIG_BROKEN so that users cannot
>>> enable this driver without knowing that it is broken.
>>>
>>> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
>>
>>> @@ -78,9 +78,6 @@ config RT2800PCI
>>>  	  This adds support for rt2800 wireless chipset family.
>>>  	  Supported chips: RT2760, RT2790, RT2860, RT2880, RT2890 & RT3052
>>>  
>>> -	  This driver is non-functional at the moment and is intended for
>>> -	  developers.
>>> -
>>>  	  When compiled as a module, this driver will be called "rt2800pci.ko".
>>>  
>>>  config RT2500USB
>>
>> This help text could have stayed, anyway..
>>
>> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> 
> It turned out that CONFIG_BROKEN is no longer an user visible option so by
> applying this change we would lose the advantage of having the upstream build
> testing and early detection of breakages related to upstream API updates.
> 
> [ I've just noticed now that rt2800pci was no longer included in the build
>   and dropped the patch from rt2800 tree. ]
> 

Yeah, I noticed that too. So I guess it is better not to apply it, as we then loose testing coverage.

---
Gertjan.