* [RFT 6/6] rtl8187se: Modify Kconfig and Makefile
@ 2009-11-09 23:31 Larry Finger
2009-11-10 9:20 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2009-11-09 23:31 UTC (permalink / raw)
To: John W Linville; +Cc: bzolnier, Bernhard Schiffner, linux-wireless
Modify configuration and builod system for rtl8187se.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-testing/drivers/net/wireless/Kconfig
===================================================================
--- wireless-testing.orig/drivers/net/wireless/Kconfig
+++ wireless-testing/drivers/net/wireless/Kconfig
@@ -294,6 +294,16 @@ config RTL8187_LEDS
depends on RTL8187 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = RTL8187)
default y
+config RTL8187SE
+ tristate "Realtek 8187SE PCI support"
+ depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
+ select EEPROM_93CX6
+ ---help---
+ This is a driver for RTL8187SE PCI-based cards. If built as a
+ module, it will be named rtl8187se.
+
+ Thanks to Realtek for their support!
+
config ADM8211
tristate "ADMtek ADM8211 support"
depends on MAC80211 && PCI && EXPERIMENTAL
Index: wireless-testing/drivers/net/wireless/Makefile
===================================================================
--- wireless-testing.orig/drivers/net/wireless/Makefile
+++ wireless-testing/drivers/net/wireless/Makefile
@@ -24,6 +24,7 @@ obj-$(CONFIG_B43LEGACY) += b43legacy/
obj-$(CONFIG_ZD1211RW) += zd1211rw/
obj-$(CONFIG_RTL8180) += rtl818x/
obj-$(CONFIG_RTL8187) += rtl818x/
+obj-$(CONFIG_RTL8187SE) += rtl818x/
# 16-bit wireless PCMCIA client drivers
obj-$(CONFIG_PCMCIA_RAYCS) += ray_cs.o
Index: wireless-testing/drivers/net/wireless/rtl818x/Makefile
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/Makefile
+++ wireless-testing/drivers/net/wireless/rtl818x/Makefile
@@ -1,7 +1,9 @@
rtl8180-objs := rtl8180_dev.o rtl8180_rtl8225.o rtl8180_sa2400.o rtl8180_max2820.o rtl8180_grf5101.o
rtl8187-objs := rtl8187_dev.o rtl8187_rtl8225.o rtl8187_leds.o rtl8187_rfkill.o
+rtl8187se-objs := rtl8187se_dev.o rtl8187se_rtl8225.o
obj-$(CONFIG_RTL8180) += rtl8180.o
obj-$(CONFIG_RTL8187) += rtl8187.o
+obj-$(CONFIG_RTL8187SE) += rtl8187se.o
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFT 6/6] rtl8187se: Modify Kconfig and Makefile
2009-11-09 23:31 [RFT 6/6] rtl8187se: Modify Kconfig and Makefile Larry Finger
@ 2009-11-10 9:20 ` Marcel Holtmann
2009-11-10 13:34 ` John W. Linville
0 siblings, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2009-11-10 9:20 UTC (permalink / raw)
To: Larry Finger
Cc: John W Linville, bzolnier, Bernhard Schiffner, linux-wireless
Hi Larry,
> Modify configuration and builod system for rtl8187se.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-testing/drivers/net/wireless/Kconfig
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/Kconfig
> +++ wireless-testing/drivers/net/wireless/Kconfig
> @@ -294,6 +294,16 @@ config RTL8187_LEDS
> depends on RTL8187 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = RTL8187)
> default y
>
> +config RTL8187SE
> + tristate "Realtek 8187SE PCI support"
> + depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
> + select EEPROM_93CX6
> + ---help---
> + This is a driver for RTL8187SE PCI-based cards. If built as a
> + module, it will be named rtl8187se.
> +
> + Thanks to Realtek for their support!
does this really belong into the help text. Having it in the copyright
header seems enough. Especially since this help text is not offering any
additional advice or information for the user.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFT 6/6] rtl8187se: Modify Kconfig and Makefile
2009-11-10 9:20 ` Marcel Holtmann
@ 2009-11-10 13:34 ` John W. Linville
2009-11-10 15:40 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: John W. Linville @ 2009-11-10 13:34 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Larry Finger, bzolnier, Bernhard Schiffner, linux-wireless
On Tue, Nov 10, 2009 at 10:20:55AM +0100, Marcel Holtmann wrote:
> Hi Larry,
>
> > Modify configuration and builod system for rtl8187se.
> >
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > ---
> >
> > Index: wireless-testing/drivers/net/wireless/Kconfig
> > ===================================================================
> > --- wireless-testing.orig/drivers/net/wireless/Kconfig
> > +++ wireless-testing/drivers/net/wireless/Kconfig
> > @@ -294,6 +294,16 @@ config RTL8187_LEDS
> > depends on RTL8187 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = RTL8187)
> > default y
> >
> > +config RTL8187SE
> > + tristate "Realtek 8187SE PCI support"
> > + depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
> > + select EEPROM_93CX6
> > + ---help---
> > + This is a driver for RTL8187SE PCI-based cards. If built as a
> > + module, it will be named rtl8187se.
> > +
> > + Thanks to Realtek for their support!
>
> does this really belong into the help text. Having it in the copyright
> header seems enough. Especially since this help text is not offering any
> additional advice or information for the user.
FWIW, I think Larry basically copied that from the other Realtek
entries. But you are right, it should probably be gone...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFT 6/6] rtl8187se: Modify Kconfig and Makefile
2009-11-10 13:34 ` John W. Linville
@ 2009-11-10 15:40 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2009-11-10 15:40 UTC (permalink / raw)
To: John W. Linville
Cc: Marcel Holtmann, bzolnier, Bernhard Schiffner, linux-wireless
On 11/10/2009 07:34 AM, John W. Linville wrote:
> On Tue, Nov 10, 2009 at 10:20:55AM +0100, Marcel Holtmann wrote:
>> Hi Larry,
>>
>>> Modify configuration and builod system for rtl8187se.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> ---
>>>
>>> Index: wireless-testing/drivers/net/wireless/Kconfig
>>> ===================================================================
>>> --- wireless-testing.orig/drivers/net/wireless/Kconfig
>>> +++ wireless-testing/drivers/net/wireless/Kconfig
>>> @@ -294,6 +294,16 @@ config RTL8187_LEDS
>>> depends on RTL8187 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = RTL8187)
>>> default y
>>>
>>> +config RTL8187SE
>>> + tristate "Realtek 8187SE PCI support"
>>> + depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
>>> + select EEPROM_93CX6
>>> + ---help---
>>> + This is a driver for RTL8187SE PCI-based cards. If built as a
>>> + module, it will be named rtl8187se.
>>> +
>>> + Thanks to Realtek for their support!
>>
>> does this really belong into the help text. Having it in the copyright
>> header seems enough. Especially since this help text is not offering any
>> additional advice or information for the user.
>
> FWIW, I think Larry basically copied that from the other Realtek
> entries. But you are right, it should probably be gone...
That is exactly what happened, but it is gone now.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-10 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-09 23:31 [RFT 6/6] rtl8187se: Modify Kconfig and Makefile Larry Finger
2009-11-10 9:20 ` Marcel Holtmann
2009-11-10 13:34 ` John W. Linville
2009-11-10 15:40 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).