From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Rui Paulo <rpaulo@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 11/20] mac80211: implement RANN processing and forwarding
Date: Tue, 10 Nov 2009 19:19:45 -0500 [thread overview]
Message-ID: <20091111001944.GA3087@tuxdriver.com> (raw)
In-Reply-To: <1257894879.7037.70.camel@johannes.local>
On Wed, Nov 11, 2009 at 12:14:39AM +0100, Johannes Berg wrote:
> On Tue, 2009-11-10 at 23:03 +0000, Rui Paulo wrote:
> > Hi John,
> >
> > On 10 Nov 2009, at 21:43, John W. Linville wrote:
> > > In file included from net/wireless/lib80211.c:19:
> > > include/linux/ieee80211.h:566: error: ‘ETH_ALEN’ undeclared here (not in a function)
> >
> > Hmm, I must've busted my testing procedure. I'm sorry.
> >
> > Anyway, I noticed that nothing uses ETH_ALEN in ieee80211.h and there
> > are quite some places we could use it. Should we include if_ether.h in
> > ieee80211.h (probably too evil) or should I just keep using 6 instead
> > of ETH_ALEN ?
>
> When John mentioned this I remembered falling into that trap before ..
> maybe better to just keep using 6, sorry!
I don't much care either way. FWIW I would tend to prefer ETH_ALEN
over 6, so long as it doesn't break the build... :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2009-11-11 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 13:48 [PATCH v3 11/20] mac80211: implement RANN processing and forwarding Rui Paulo
2009-11-10 21:43 ` John W. Linville
[not found] ` <1E46D638-5BD4-4B59-9800-9A70595720B9@gmail.com>
2009-11-10 23:14 ` Johannes Berg
2009-11-11 0:19 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111001944.GA3087@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rpaulo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).