From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
Ivo van Doorn <IvDoorn@gmail.com>
Subject: Re: [PATCH] rt2x00: Fix rt2800lib RF chip programming selection.
Date: Thu, 12 Nov 2009 20:25:55 +0100 [thread overview]
Message-ID: <200911122025.55944.bzolnier@gmail.com> (raw)
On Monday 09 November 2009 22:59:58 Gertjan van Wingerde wrote:
> Mirror the legacy Ralink driver with respect to rt2800 RF register programming. Execute
> rt2800_config_channel_rt3x for all RF2020, RF3020, RF3021 & RF3022 chipsets when operating on RT3070
> devices.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
checkpatch.pl complains about:
ERROR: trailing whitespace
#27: FILE: drivers/net/wireless/rt2x00/rt2800lib.c:809:
+^Iif (rt2x00_rt(&rt2x00dev->chip, RT3070) &&^I$
ERROR: code indent should use tabs where possible
#28: FILE: drivers/net/wireless/rt2x00/rt2800lib.c:810:
+ (rt2x00_rf(&rt2x00dev->chip, RF2020) ||$
I fixed those while applying patch to rt2800 tree..
[ This was fixed later in "[PATCH v2] rt2x00: Initialize rf302x RF values
properly for rt2800pci." but we want all patches to be checkpatch.pl
clean as otherwise it is confusing for people doing automated checking ]
next reply other threads:[~2009-11-12 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 19:25 Bartlomiej Zolnierkiewicz [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-09 21:59 [PATCH] rt2x00: Fix rt2800lib RF chip programming selection Gertjan van Wingerde
2009-11-10 18:33 ` Ivo van Doorn
2009-11-11 22:07 ` John W. Linville
2009-11-11 23:22 ` Gertjan van Wingerde
2009-11-11 23:35 ` John W. Linville
2009-11-12 0:03 ` Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911122025.55944.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=IvDoorn@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).