From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jouni Malinen <Jouni.Malinen@Atheros.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH 2/2] ath9k_hw: Fix AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_BB and its shift value in 0x4054
Date: Mon, 16 Nov 2009 07:36:46 -0800 [thread overview]
Message-ID: <20091116153646.GC4237@tux> (raw)
In-Reply-To: <20091116072004.GC27858@vasanth-laptop>
On Sun, Nov 15, 2009 at 11:20:07PM -0800, Vasanth Thiagarajan wrote:
> On Fri, Nov 13, 2009 at 10:44:38PM +0530, Luis Rodriguez wrote:
> > On Fri, Nov 13, 2009 at 01:02:40AM -0800, Vasanth Thiagarajan wrote:
> > > The bit value of AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_BB is wrong, it should
> > > be 0x400 and the number of bits to be right shifted is 10. Having this
> > > wrong value in 0x4054 sometimes affects bt quality on btcoex environment.
> > >
> > > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> >
> > These both seem small enough and reasonable for stable fixes no?
>
> yeah, I'll resend them CC'ing stable.
>
> > Although I didn't get the impact of the first one..
>
> debruijn32 (0x077CB531UL) is used to find the index of the geric timer
> which generated the interrupt. On a 64-bit environment, 0x077CB531UL
> will result in indexing more than 32 in gen_timer_index[] which has
> memory allocated only for 32 u32.
Can this be added to the commit log?
Luis
next prev parent reply other threads:[~2009-11-16 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 9:02 [PATCH 1/2] ath9k_hw: Fix possible OOB array indexing in gen_timer_index[] on 64-bit Vasanthakumar Thiagarajan
2009-11-13 9:02 ` [PATCH 2/2] ath9k_hw: Fix AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_BB and its shift value in 0x4054 Vasanthakumar Thiagarajan
2009-11-13 17:14 ` Luis R. Rodriguez
2009-11-16 7:20 ` Vasanthakumar Thiagarajan
2009-11-16 15:36 ` Luis R. Rodriguez [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-23 8:24 [PATCH 1/2] ath9k_hw: Fix possible OOB array indexing in gen_timer_index[] on 64-bit vasanth
2009-12-23 8:24 ` [PATCH 2/2] ath9k_hw: Fix AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_BB and its shift value in 0x4054 vasanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116153646.GC4237@tux \
--to=lrodriguez@atheros.com \
--cc=Jouni.Malinen@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).