From: Stephen Hemminger <shemminger@vyatta.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>, netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [RFC] mac80211: disallow bridging managed/adhoc interfaces
Date: Tue, 17 Nov 2009 08:37:41 -0800 [thread overview]
Message-ID: <20091117083741.1b165274@nehalam> (raw)
In-Reply-To: <1258466868.3682.13.camel@johannes.local>
On Tue, 17 Nov 2009 15:07:48 +0100
Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2009-11-17 at 15:04 +0100, Michael Buesch wrote:
> > On Tuesday 17 November 2009 14:46:25 Johannes Berg wrote:
> > > --- wireless-testing.orig/net/bridge/br_if.c 2009-11-17 14:19:17.000000000 +0100
> > > +++ wireless-testing/net/bridge/br_if.c 2009-11-17 14:20:03.000000000 +0100
> > > @@ -390,6 +390,10 @@ int br_add_if(struct net_bridge *br, str
> > > if (dev->br_port != NULL)
> > > return -EBUSY;
> > >
> > > + /* No bridging devices that dislike that (e.g. wireless) */
> > > + if (dev->priv_flags & IFF_DONT_BRIDGE)
> > > + return -EINVAL;
> >
> > -EOPNOTSUPP?
> > That would probably produce a better error message in userspace.
But there are people bridging wireless, and hostap even has a mode for
that. Especially people are bridging to wireless when the other interfaces
are VMs.
next prev parent reply other threads:[~2009-11-17 16:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 13:46 [RFC] mac80211: disallow bridging managed/adhoc interfaces Johannes Berg
2009-11-17 13:58 ` John W. Linville
2009-11-17 14:04 ` Johannes Berg
2009-11-17 14:04 ` Michael Buesch
2009-11-17 14:06 ` John W. Linville
2009-11-17 14:07 ` Johannes Berg
2009-11-17 16:37 ` Stephen Hemminger [this message]
2009-11-17 16:43 ` Johannes Berg
2009-11-17 17:04 ` Stephen Hemminger
2009-11-17 17:05 ` Johannes Berg
2009-11-17 20:41 ` Dan Williams
2009-11-17 20:48 ` [RFC v2] " Johannes Berg
2009-11-17 22:42 ` Julian Calaby
2009-11-17 22:46 ` Johannes Berg
2009-11-17 22:50 ` Julian Calaby
2009-11-17 22:42 ` Stephen Hemminger
2009-11-17 22:45 ` Johannes Berg
2009-11-18 1:59 ` Stefan Monnier
2009-11-18 2:59 ` John W. Linville
2009-11-18 10:52 ` Johannes Berg
2009-12-11 12:39 ` [RFC] " Markus Baier
2009-12-11 13:00 ` Johannes Berg
2009-12-11 13:18 ` Markus Baier
2009-12-11 13:58 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117083741.1b165274@nehalam \
--to=shemminger@vyatta.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).