[PATCH 1/1] Adding radio type FM

[PATCH 1/1] Adding radio type FM

[Janakiram Sistla]

Adding changes  RFKILL type FM  and for RFKILL for FM  in core

>From 4bf0ae6c90de9a766914abeb5ab5e5428089b648 Mon Sep 17 00:00:00 2001
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Date: Mon, 16 Nov 2009 07:58:09 +0530
Subject: [PATCH 1/1] Adding radio type FM

Adding radio type FM in RFKILL_TYPE_.FM belongs to
same class of with both TX/RX capability.

Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
 include/linux/rfkill.h |    1 +
 net/rfkill/core.c      |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..03f5598 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -45,6 +45,7 @@ enum rfkill_type {
 	RFKILL_TYPE_WIMAX,
 	RFKILL_TYPE_WWAN,
 	RFKILL_TYPE_GPS,
+	RFKILL_TYPE_FM,
 	NUM_RFKILL_TYPES,
 };

diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..61b716e 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum
rfkill_type type)
 		return "wimax";
 	case RFKILL_TYPE_WWAN:
 		return "wwan";
+	case RFKILL_TYPE_FM:
+		return "fm";
 	case RFKILL_TYPE_GPS:
 		return "gps";
 	default:
-- 
1.5.4.3

Re: [PATCH 1/1] Adding radio type FM

[Marcel Holtmann]

Hi Janakiram,

so first of all, please stop sending emails to majordomo. That is not a
real person.

> Adding changes  RFKILL type FM  and for RFKILL for FM  in core
> 
> From 4bf0ae6c90de9a766914abeb5ab5e5428089b648 Mon Sep 17 00:00:00 2001
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> Date: Mon, 16 Nov 2009 07:58:09 +0530
> Subject: [PATCH 1/1] Adding radio type FM
> 
> Adding radio type FM in RFKILL_TYPE_.FM belongs to
> same class of with both TX/RX capability.
> 
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>

the patch itself is fine, but can we get at least one with a proper
commit message. And if you mailer is broken, then either fix it or use
git send-email.

Regards

Marcel

Re: [PATCH 1/1] Adding radio type FM

[Janakiram Sistla]

Hi Marcel,

I am sorry about this.There is a problem with my git send-email.so i
had to use the mailer.I will surely take complete precaution that it
will not repeat further.

Regards,
Ram.

On 11/16/09, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
> so first of all, please stop sending emails to majordomo. That is not a
> real person.
>
> > Adding changes  RFKILL type FM  and for RFKILL for FM  in core
> >
> > From 4bf0ae6c90de9a766914abeb5ab5e5428089b648 Mon Sep 17 00:00:00 2001
> > From: Janakiram Sistla <janakiram.sistla@gmail.com>
> > Date: Mon, 16 Nov 2009 07:58:09 +0530
> > Subject: [PATCH 1/1] Adding radio type FM
> >
> > Adding radio type FM in RFKILL_TYPE_.FM belongs to
> > same class of with both TX/RX capability.
> >
> > Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
>
> the patch itself is fine, but can we get at least one with a proper
> commit message. And if you mailer is broken, then either fix it or use
> git send-email.
>
> Regards
>
> Marcel
>
>
>

[PATCH 1/1] Adding radio type FM

[Janakiram Sistla]

From: Janakiram Sistla <janakiram.sistla@gmail.com>

Adding radio type FM in RFKILL_TYPE_.FM belongs to
same class of with both TX/RX capability.

Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
 include/linux/rfkill.h |    1 +
 net/rfkill/core.c      |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..03f5598 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -45,6 +45,7 @@ enum rfkill_type {
 	RFKILL_TYPE_WIMAX,
 	RFKILL_TYPE_WWAN,
 	RFKILL_TYPE_GPS,
+	RFKILL_TYPE_FM,
 	NUM_RFKILL_TYPES,
 };
 
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..61b716e 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
 		return "wimax";
 	case RFKILL_TYPE_WWAN:
 		return "wwan";
+	case RFKILL_TYPE_FM:
+		return "fm";
 	case RFKILL_TYPE_GPS:
 		return "gps";
 	default:
-- 
1.5.4.3

Re: [PATCH 1/1] Adding radio type FM

[John W. Linville]

On Tue, Nov 17, 2009 at 11:18:33PM +0530, Janakiram Sistla wrote:
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> 
> Adding radio type FM in RFKILL_TYPE_.FM belongs to
> same class of with both TX/RX capability.
> 
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
>  include/linux/rfkill.h |    1 +
>  net/rfkill/core.c      |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..03f5598 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -45,6 +45,7 @@ enum rfkill_type {
>  	RFKILL_TYPE_WIMAX,
>  	RFKILL_TYPE_WWAN,
>  	RFKILL_TYPE_GPS,
> +	RFKILL_TYPE_FM,
>  	NUM_RFKILL_TYPES,
>  };
>  
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index ba2efb9..61b716e 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
>  		return "wimax";
>  	case RFKILL_TYPE_WWAN:
>  		return "wwan";
> +	case RFKILL_TYPE_FM:
> +		return "fm";
>  	case RFKILL_TYPE_GPS:
>  		return "gps";
>  	default:

My personal taste would dictate that you add the case statement
in the same place that you added the enum.  Depending on which
order you choose, you may need to change the BUILD_BUG_ON on line
601 of net/rfkill/core.c.  (Not sure how you managed to build w/
this patch...)

Also, when you add the enum you need to add the corresponding kerneldoc
(i.e. an @RFKILL_TYPE_FM comment) just above it.

Finally, please add "rfkill: " to the beginning of the subject line
when you resubmit your patch.

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH 1/1] Adding radio type FM

[John W. Linville]

On Tue, Nov 17, 2009 at 01:31:50PM -0500, John W. Linville wrote:

> My personal taste would dictate that you add the case statement
> in the same place that you added the enum.  Depending on which

s/place/order/

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.