From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:37755 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbZKRPaa (ORCPT ); Wed, 18 Nov 2009 10:30:30 -0500 Date: Wed, 18 Nov 2009 10:29:10 -0500 From: "John W. Linville" To: Felix Fietkau Cc: linux-wireless , "Luis R. Rodriguez" Subject: Re: [PATCH v2 1/2] ath9k: properly use the mac80211 rate control api Message-ID: <20091118152909.GC2911@tuxdriver.com> References: <4B037881.8020509@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <4B037881.8020509@openwrt.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 18, 2009 at 05:30:57AM +0100, Felix Fietkau wrote: > This patch changes ath9k to pass proper MCS indexes and flags > between the RC and the rest of the driver code. > sc->cur_rate_table remains, as it's used by the RC code internally, > but the rest of the driver code no longer uses it, so a potential > new RC for ath9k would not have to update it. > > Signed-off-by: Felix Fietkau > --- > - replaces sc->hw usage with common->hw > - initializes unused tx status rates to -1 for minstrel compatibility > - split up for easier review > - tested in ap mode with minstrel against a legacy STA > - v2: fix bisectability CC [M] drivers/net/wireless/ath/ath9k/rc.o drivers/net/wireless/ath/ath9k/rc.c: In function ‘ath_tx_status’: drivers/net/wireless/ath/ath9k/rc.c:1272: warning: passing argument 2 of ‘ath_debug_stat_rc’ makes pointer from integer without a cast drivers/net/wireless/ath/ath9k/debug.h:173: note: expected ‘struct sk_buff *’ but argument is of type ‘int’ -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.