From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: move TX status processing to process context
Date: Wed, 18 Nov 2009 13:12:01 -0800 [thread overview]
Message-ID: <20091118211201.GJ6581@tux> (raw)
In-Reply-To: <20091118210654.GI6581@tux>
On Wed, Nov 18, 2009 at 01:06:54PM -0800, Luis Rodriguez wrote:
>
> OK, but can't you still have a driver spam mac80211 with a lot of
> ieee80211_tx_status_irqsafe() calls in soft irq context with the final
> skb requiring the tx complete, in that case the queue *will* get stuffed
> and you could potentially free more if so desired.
>
> Also, if our goal is to just avoid adding the skb if it does not require
> a tx complete and our queue size is too large
Hit send too early, I meant if our goal is to avoid adding the skb
if we've reached our limit why not just ree it immediately instead
of queing it and dequeing it. Wouldn't we even be able to just
return and not bother mac80211 about it at all?
>
> if (!(info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS) &&
> num + 1 > IEEE80211_TX_STATUS_QUEUE_LIMIT)
{
> dev_kfree_skb_irq(skb);
return;
}
> else
> skb_queue_tail(&local->skb_queue)
next prev parent reply other threads:[~2009-11-18 21:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 19:16 [RFC] mac80211: move TX status processing to process context Johannes Berg
2009-11-18 19:53 ` Luis R. Rodriguez
2009-11-18 20:01 ` Johannes Berg
2009-11-18 20:23 ` Luis R. Rodriguez
2009-11-18 20:34 ` Johannes Berg
2009-11-18 21:06 ` Luis R. Rodriguez
2009-11-18 21:11 ` Johannes Berg
2009-11-18 21:15 ` Luis R. Rodriguez
2009-11-18 21:12 ` Luis R. Rodriguez [this message]
2009-11-18 21:13 ` Johannes Berg
2009-11-19 13:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118211201.GJ6581@tux \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@bombadil.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox