From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: Unconditionally log results of core scans
Date: Thu, 19 Nov 2009 21:13:33 +0100 [thread overview]
Message-ID: <200911192113.35757.mb@bu3sch.de> (raw)
In-Reply-To: <4b059ffa.0PbmHUedj2WTwpAO%Larry.Finger@lwfinger.net>
On Thursday 19 November 2009 20:43:54 Larry Finger wrote:
> At present, the results of an SSB core scan are only logged when
> CONFIG_SSB_DEBUG is "y". As this may not be set in a distro kernel,
> it is difficult interpret many problems posted in bug reports or in
> help forums.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-testing/drivers/ssb/scan.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/scan.c
> +++ wireless-testing/drivers/ssb/scan.c
> @@ -354,7 +354,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
> dev->bus = bus;
> dev->ops = bus->ops;
>
> - ssb_dprintk(KERN_INFO PFX
> + printk(KERN_INFO PFX
> "Core %d found: %s "
> "(cc 0x%03X, rev 0x%02X, vendor 0x%04X)\n",
> i, ssb_core_name(dev->id.coreid),
>
>
Please use KERN_DEBUG
--
Greetings, Michael.
prev parent reply other threads:[~2009-11-19 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 19:43 [PATCH] ssb: Unconditionally log results of core scans Larry Finger
2009-11-19 20:13 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911192113.35757.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).