* [PATCH] ssb: Unconditionally log results of core scans
@ 2009-11-19 19:43 Larry Finger
2009-11-19 20:13 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2009-11-19 19:43 UTC (permalink / raw)
To: John W Linville, Michael Buesch; +Cc: bcm43xx-dev, linux-wireless
At present, the results of an SSB core scan are only logged when
CONFIG_SSB_DEBUG is "y". As this may not be set in a distro kernel,
it is difficult interpret many problems posted in bug reports or in
help forums.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-testing/drivers/ssb/scan.c
===================================================================
--- wireless-testing.orig/drivers/ssb/scan.c
+++ wireless-testing/drivers/ssb/scan.c
@@ -354,7 +354,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
dev->bus = bus;
dev->ops = bus->ops;
- ssb_dprintk(KERN_INFO PFX
+ printk(KERN_INFO PFX
"Core %d found: %s "
"(cc 0x%03X, rev 0x%02X, vendor 0x%04X)\n",
i, ssb_core_name(dev->id.coreid),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ssb: Unconditionally log results of core scans
2009-11-19 19:43 [PATCH] ssb: Unconditionally log results of core scans Larry Finger
@ 2009-11-19 20:13 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2009-11-19 20:13 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, bcm43xx-dev, linux-wireless
On Thursday 19 November 2009 20:43:54 Larry Finger wrote:
> At present, the results of an SSB core scan are only logged when
> CONFIG_SSB_DEBUG is "y". As this may not be set in a distro kernel,
> it is difficult interpret many problems posted in bug reports or in
> help forums.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-testing/drivers/ssb/scan.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/scan.c
> +++ wireless-testing/drivers/ssb/scan.c
> @@ -354,7 +354,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
> dev->bus = bus;
> dev->ops = bus->ops;
>
> - ssb_dprintk(KERN_INFO PFX
> + printk(KERN_INFO PFX
> "Core %d found: %s "
> "(cc 0x%03X, rev 0x%02X, vendor 0x%04X)\n",
> i, ssb_core_name(dev->id.coreid),
>
>
Please use KERN_DEBUG
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-19 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-19 19:43 [PATCH] ssb: Unconditionally log results of core scans Larry Finger
2009-11-19 20:13 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).