Re: [rt2x00-users] [PATCH v2 1/8] rt2x00: Only initialize HT on rt2800 devices that support it.

[Ivo van Doorn <ivdoorn@gmail.com>]

On Monday 23 November 2009, David Ellingsworth wrote:
> On Mon, Nov 23, 2009 at 4:44 PM, Gertjan van Wingerde
> <gwingerde@gmail.com> wrote:
> > Some RT28xx/RT30xx devices don't support 802.11n, when they are combined with
> > the RF2020 chipset. Ensure that HT is disabled for these devices.
> >
> > Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> > ---
> >  drivers/net/wireless/rt2x00/rt2800lib.c |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> > index e94f1e1..fcd0c88 100644
> > --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> > @@ -2072,7 +2072,11 @@ int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
> >        /*
> >         * Initialize HT information.
> >         */
> > -       spec->ht.ht_supported = true;
> > +       if (!rt2x00_rf(chip, RF2020))
> > +               spec->ht.ht_supported = true;
> > +       else
> > +               spec->ht.ht_supported = false;
> > +
> 
> Maybe I'm the only one, but I hate conditional statements with no
> meaning. Maybe this instead?
> 
> spec->ht.ht_supported = !rt2x00_rf(chip, RF2020);

I think this would look better as well. But either way you can add my:

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>