From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: Michael Buesch <mb@bu3sch.de>
Cc: "Hin-Tak Leung" <htl10@users.sourceforge.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
"linux-wireless" <linux-wireless@vger.kernel.org>
Subject: Re: RTL8187 warnings on suspend
Date: Wed, 25 Nov 2009 19:44:25 -0200 [thread overview]
Message-ID: <200911251944.25381.herton@mandriva.com.br> (raw)
In-Reply-To: <200911252157.41899.mb@bu3sch.de>
Em Qua 25 Nov 2009, às 18:57:40, Michael Buesch escreveu:
> On Wednesday 25 November 2009 20:55:00 Herton Ronaldo Krzesinski wrote:
> > Em Qua 25 Nov 2009, às 17:29:21, Michael Buesch escreveu:
> > > On Wednesday 25 November 2009 19:25:39 Herton Ronaldo Krzesinski wrote:
> > > > of the led inside rtl8187_leds_exit, like the patch below, could you try it?
> > >
> > > Does not completely fix it
> >
> > Indeed, ieee80211_queue_delayed_work run also in rtl8187_led_brightness_set...
> > my patch didn't fix anything... I think the only way is starting and stopping
> > leds in start and stop, the following patch should do it:
>
> That completely crashes the machine on suspend. I can take a picture of the crash,
> but I guess you can easily reproduce it...
Hmm strange, reviewing it now I only see a missing #ifdef CONFIG_RTL8187_LEDS
around rtl8187_leds_start inside rtl8187_start. Despite it, the patch worked
here, may be something I'm not seeing...
--
[]'s
Herton
next prev parent reply other threads:[~2009-11-25 21:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 15:26 RTL8187 warnings on suspend Michael Buesch
2009-11-25 18:25 ` Herton Ronaldo Krzesinski
2009-11-25 19:29 ` Michael Buesch
2009-11-25 19:55 ` Herton Ronaldo Krzesinski
2009-11-25 20:57 ` Michael Buesch
2009-11-25 21:44 ` Herton Ronaldo Krzesinski [this message]
2009-11-25 22:18 ` Michael Buesch
2009-11-25 23:18 ` Herton Ronaldo Krzesinski
2009-11-26 18:04 ` Herton Ronaldo Krzesinski
2009-11-27 0:10 ` Hin-Tak Leung
2009-11-27 11:45 ` Herton Ronaldo Krzesinski
2009-11-27 12:33 ` Hin-Tak Leung
2009-11-27 17:49 ` Larry Finger
2009-12-01 13:49 ` Herton Ronaldo Krzesinski
2009-12-01 20:11 ` Larry Finger
2009-12-01 21:26 ` Herton Ronaldo Krzesinski
2009-12-01 22:21 ` Larry Finger
2009-12-08 22:01 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911251944.25381.herton@mandriva.com.br \
--to=herton@mandriva.com.br \
--cc=Larry.Finger@lwfinger.net \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).