* [PATCH] airo: Fix integer overflow warning
@ 2009-11-25 21:55 Michael Buesch
0 siblings, 0 replies; only message in thread
From: Michael Buesch @ 2009-11-25 21:55 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
On BigEndian gcc complains:
drivers/net/wireless/airo.c: In function ‘sniffing_mode’:
drivers/net/wireless/airo.c:4809: warning: integer overflow in expression
Fix this by doing the bitwise AND on the host-endian value.
---
I don't know why GCC warns, however. The original code looks OK to me, too.
Index: wireless-testing/drivers/net/wireless/airo.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/airo.c 2009-11-01 13:58:47.000000000 +0100
+++ wireless-testing/drivers/net/wireless/airo.c 2009-11-25 22:49:18.000000000 +0100
@@ -4806,7 +4806,7 @@ static int airo_config_commit(struct net
static inline int sniffing_mode(struct airo_info *ai)
{
- return le16_to_cpu(ai->config.rmode & RXMODE_MASK) >=
+ return (le16_to_cpu(ai->config.rmode) & le16_to_cpu(RXMODE_MASK)) >=
le16_to_cpu(RXMODE_RFMON);
}
--
Greetings, Michael.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-11-25 21:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-25 21:55 [PATCH] airo: Fix integer overflow warning Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).