* Re: [PATCH] rt2x00: Fix padding bug on L2PAD devices.
[not found] <1259100692-23315-1-git-send-email-gwingerde@gmail.com>
@ 2009-11-25 23:49 ` Ivo van Doorn
0 siblings, 0 replies; only message in thread
From: Ivo van Doorn @ 2009-11-25 23:49 UTC (permalink / raw)
To: Gertjan van Wingerde; +Cc: users, linux-wireless
On Tuesday 24 November 2009, Gertjan van Wingerde wrote:
> While reviewing the l2pad function to align both the header and the payload
> on a DMA-capable boundary a bug was discovered where the payload would not
> be properly aligned. The header_align value was used where the payload_align
> value should have been used.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2x00queue.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.c b/drivers/net/wireless/rt2x00/rt2x00queue.c
> index 32d4aea..239afc7 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00queue.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00queue.c
> @@ -214,7 +214,7 @@ void rt2x00queue_insert_l2pad(struct sk_buff *skb, unsigned int header_length)
> skb_push(skb, header_align);
> memmove(skb->data, skb->data + header_align, header_length);
> memmove(skb->data + header_length + l2pad,
> - skb->data + header_length + l2pad + header_align,
> + skb->data + header_length + l2pad + payload_align,
> frame_length - header_length);
> skbdesc->flags |= SKBDESC_L2_PADDED;
> }
^ permalink raw reply [flat|nested] only message in thread