linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Shahar Or <mightyiampresence@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org,
	me@bobcopeland.com
Subject: Re: [PATCH] ath5k: add support for Dell Vostro A860 LED
Date: Fri, 4 Dec 2009 14:23:15 -0500	[thread overview]
Message-ID: <20091204192315.GA5786@tuxdriver.com> (raw)
In-Reply-To: <bf87febf0912030507u1c36f6a9h7cac0efabf3d016@mail.gmail.com>

This patch is whitespace-damaged, you don't have your email address
in the Signed-off-by or From lines (the latter being unnecessary
anyway), and even after I took the time to fix those issues it still
didn't apply.

Feel free to try again...thanks.

JOhn

On Thu, Dec 03, 2009 at 03:07:28PM +0200, Shahar Or wrote:
> From: Shahar Or
> 
> Adds support for the WiFi activity LED on the Dell Vostro A860 laptop.
> 
> Signed-off-by: Shahar Or
> 
> ---
> --- linux-2.6.31/drivers/net/wireless/ath/ath5k/led.c.orig
> 2009-12-03 14:57:20.000000000 +0200
> +++ linux-2.6.31/drivers/net/wireless/ath/ath5k/led.c   2009-12-03
> 14:25:30.000000000 +0200
> @@ -71,6 +71,8 @@ static const struct pci_device_id ath5k_
>         { ATH_SDEVICE(PCI_VENDOR_ID_IBM, 0x058a), ATH_LED(1, 0) },
>         /* IBM-specific AR5212 (all others) */
>         { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM),
> ATH_LED(0, 0) },
> +       /* Dell Vostro A860 (shahar@shahar-or.co.il) */
> +       { ATH_SDEVICE(PCI_VENDOR_ID_QMI, 0x0112), ATH_LED(3, 0) },
>         { }
>  };
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2009-12-04 19:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 13:07 [PATCH] ath5k: add support for Dell Vostro A860 LED Shahar Or
2009-12-04 19:23 ` John W. Linville [this message]
2009-12-07 10:05   ` Shahar Or
2009-12-07 21:59     ` John W. Linville
2009-12-08 14:57       ` [ath5k-devel] " Bob Copeland
2009-12-08 16:01         ` Luis R. Rodriguez
2009-12-08 16:06           ` John W. Linville
2009-12-08 16:30             ` Luis R. Rodriguez
2009-12-18 11:42               ` Shahar Or
2009-12-18 15:37                 ` Luis R. Rodriguez
2009-12-18 16:23                   ` Luis R. Rodriguez
2009-12-18 17:03                   ` Shahar Or
2009-12-18 17:19                     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091204192315.GA5786@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@bobcopeland.com \
    --cc=mightyiampresence@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).