From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
John W Linville <linville@tuxdriver.com>,
"Hin-Tak Leung" <htl10@users.sourceforge.net>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC/RFT] rtl8187: Fix 'queuing ieee80211 work while going to suspend' warning
Date: Tue, 8 Dec 2009 19:07:23 -0200 [thread overview]
Message-ID: <200912081907.23949.herton@mandriva.com.br> (raw)
In-Reply-To: <4B1EBE86.7000303@lwfinger.net>
Em Ter 08 Dez 2009, às 19:00:54, Larry Finger escreveu:
> On 12/08/2009 02:57 PM, Herton Ronaldo Krzesinski wrote:
> > It's because without registering a radio led the current behaviour is
> > wrong for some cases, the led stays on when it shouldn't. For example, if
> > you bring the interface down (ifconfig <if> down) the led stays on, when
> > it shouldn't. The led should only be active while interface is active,
> > between start and stop (or in other words, the radio is on). After
> > mac80211 stops the device, any i/o (led activity) shouldn't happen.
>
> OK, then the turn off of the radio LED eliminates the "turn-off" that
> I put in the shutdown process.
Yes, but note it isn't the same thing, only if the turn off happened at
rtl8187_stop, which doesn't happen at the moment, the led should be turned off
at _stop.
>
> Larry
>
--
[]'s
Herton
next prev parent reply other threads:[~2009-12-08 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 2:08 [RFC/RFT] rtl8187: Fix 'queuing ieee80211 work while going to suspend' warning Larry Finger
2009-12-08 11:02 ` Michael Buesch
2009-12-08 15:41 ` Larry Finger
2009-12-08 15:41 ` Herton Ronaldo Krzesinski
2009-12-08 20:16 ` Larry Finger
2009-12-08 20:57 ` Herton Ronaldo Krzesinski
2009-12-08 21:00 ` Larry Finger
2009-12-08 21:07 ` Herton Ronaldo Krzesinski [this message]
2009-12-08 22:18 ` Hin-Tak Leung
2009-12-08 22:23 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912081907.23949.herton@mandriva.com.br \
--to=herton@mandriva.com.br \
--cc=Larry.Finger@lwfinger.net \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).