public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Seyfried <stefan.seyfried@googlemail.com>
To: Dan Williams <dcbw@redhat.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Add support for Sphairon Homelink 1202 USB WLAN
Date: Fri, 11 Dec 2009 23:37:09 +0100	[thread overview]
Message-ID: <20091211233709.29fc5312@strolchi.home.s3e.de> (raw)
In-Reply-To: <1260559270.6254.2.camel@localhost.localdomain>

On Fri, 11 Dec 2009 11:21:10 -0800
Dan Williams <dcbw@redhat.com> wrote:

> On Fri, 2009-12-11 at 16:01 +0100, Stefan Seyfried wrote:
> > Maybe a separate driver that is ejecting all those fake storage
> > devices, be it 3G modems or wireless LAN might be a good idea, but I am
> > probably not the right one to code that ;)
> > Or maybe we decide that userspace should handle it for all devices...
> 
> If the device actually changes USB IDs after the switch, then the right

Yes, it does.

> place to put this code is probably unusual_devs instead of
> touching /two/ drivers.  I'd say extract the code from zd1211rw and put
> the new code that works for both zd1211rw/ar9170 into unusual_devs.  In
> fact, people might be happier if you posted two patches, (1) move the
> code to unusual_devs unchanged, and (2) fix up the moved code to support
> the new device's behavior.

Ok, I'll do this next week (might take some time, since I need to get
familiar with the usb / unusual_devs code). I guess this will mostly go
through Greg then?

John, please take the patch 1, that adds the USB ID to ar9170usb. It is
useful on its own since the device can also be switched with
usb_modeswitch from userspace, and it is really trivial.

Thanks,

	Stefan
-- 
Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out."

  reply	other threads:[~2009-12-11 22:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 14:21 [PATCH 0/2] Add support for Sphairon Homelink 1202 USB WLAN Stefan Seyfried
2009-12-08 14:21 ` [PATCH 1/2] ar9170usb: add Sphairon Homelink 1202 USB ID Stefan Seyfried
2009-12-08 14:21   ` [PATCH 2/2] zd1211rw: improve ejecting of fake CDROM Stefan Seyfried
2009-12-11 12:36 ` [PATCH 0/2] Add support for Sphairon Homelink 1202 USB WLAN Stefan Seyfried
2009-12-11 14:42   ` John W. Linville
2009-12-11 14:55     ` Johannes Berg
2009-12-11 15:05       ` Stefan Seyfried
2009-12-11 15:01     ` Stefan Seyfried
2009-12-11 19:21       ` Dan Williams
2009-12-11 22:37         ` Stefan Seyfried [this message]
2009-12-15 12:17           ` Stefan Seyfried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091211233709.29fc5312@strolchi.home.s3e.de \
    --to=stefan.seyfried@googlemail.com \
    --cc=dcbw@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox