From: Randy Dunlap <randy.dunlap@oracle.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: linville@tuxdriver.com, users@rt2x00.serialmonkey.com,
linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib.
Date: Sat, 12 Dec 2009 19:54:36 -0800 [thread overview]
Message-ID: <20091212195436.62bb66d8.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1260661180-2300-1-git-send-email-gwingerde@gmail.com>
On Sun, 13 Dec 2009 00:39:39 +0100 Gertjan van Wingerde wrote:
> rt2800lib incorrectly detected whether RT2800USB was enabled because
> it didn't account for a modularized RT2800USB driver.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
>
> John, this one is a fix for 2.6.33.
>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index eb1e1d0..bdc3286 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -33,6 +33,10 @@
> Abstract: rt2800 generic device routines.
> */
>
> +#ifdef CONFIG_RT2800USB_MODULE
> +#define CONFIG_RT2800USB
> +#endif
> +
The idiom that I am familiar with (and is the common one afaik)
is to use:
#if defined(CONFIG_RT2800USB) || defined(CONFIG_RT2800USB_MODULE)
Besides, it's not nice to muck with kconfig symbols outside of Kconfig files.
> #include <linux/kernel.h>
> #include <linux/module.h>
---
~Randy
next prev parent reply other threads:[~2009-12-13 3:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 23:39 [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Gertjan van Wingerde
2009-12-12 23:39 ` [PATCH 2.6.33] rt2x00: Disable powersaving for rt61pci Gertjan van Wingerde
2009-12-13 10:15 ` Ivo van Doorn
2009-12-13 15:16 ` Gertjan van Wingerde
2009-12-13 15:18 ` Ivo van Doorn
2009-12-13 15:21 ` Gertjan van Wingerde
2009-12-13 15:45 ` [rt2x00-users] " Benoit PAPILLAULT
2009-12-14 19:27 ` Gertjan van Wingerde
2009-12-13 3:54 ` Randy Dunlap [this message]
2009-12-13 10:14 ` [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Ivo van Doorn
2009-12-14 19:13 ` [PATCH] " John W. Linville
2009-12-14 19:24 ` Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091212195436.62bb66d8.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).