From: Daniel Mack <daniel@caiaq.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, dcbw@redhat.com,
m.hirsch@raumfeld.com, netdev@vger.kernel.org,
libertas-dev@lists.infradead.org, stable@kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs
Date: Tue, 15 Dec 2009 18:20:35 +0800 [thread overview]
Message-ID: <20091215102035.GJ28375@buzzloop.caiaq.de> (raw)
In-Reply-To: <1260871634.3692.6.camel@johannes.local>
On Tue, Dec 15, 2009 at 11:07:14AM +0100, Johannes Berg wrote:
> On Tue, 2009-12-15 at 11:03 +0100, Johannes Berg wrote:
>
> > Since you indicate the kernel crashed, it is likely that libertas is
> > treating the buffer as a string, instead of an SSID.
Ok, I dodn't know that - thanks for pointing it out. In my setup here,
SSIDs are always valid alphanumeric strings, and I was mislead by the
comment that mentions the NULL-termination.
> drivers/net/wireless/libertas$ grep lbs_deb_ * | grep ssid|grep '%s'
> assoc.c: lbs_deb_join("current SSID '%s', ssid length %u\n",
> assoc.c: lbs_deb_join("requested ssid '%s', ssid length %u\n",
> assoc.c: lbs_deb_join("ADHOC_START: SSID '%s', ssid length %u\n",
> scan.c: lbs_deb_wext("set_scan, essid '%s'\n",
Those macros are stubbed out as nops in my setup, so they can
unfortunately not be the reason. I'll dig deeper :)
Thanks,
Daniel
next prev parent reply other threads:[~2009-12-15 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1260650850-16163-1-git-send-email-daniel@caiaq.de>
2009-12-15 9:43 ` [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs David Miller
2009-12-15 10:03 ` Johannes Berg
2009-12-15 10:05 ` Johannes Berg
2009-12-15 10:07 ` Johannes Berg
2009-12-15 10:20 ` Daniel Mack [this message]
2009-12-15 10:31 ` Johannes Berg
2009-12-15 10:37 ` Daniel Mack
2009-12-15 10:30 ` Holger Schurig
2009-12-15 10:35 ` Johannes Berg
2009-12-16 6:54 ` Albert Cahalan
2009-12-16 8:19 ` Johannes Berg
2009-12-16 8:26 ` Holger Schurig
2009-12-16 3:58 ` Daniel Mack
2009-12-16 8:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215102035.GJ28375@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.hirsch@raumfeld.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).