From: Ivo van Doorn <ivdoorn@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: linville@tuxdriver.com, users@rt2x00.serialmonkey.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2.6.33] rt2x00: Fix calculation of rt2800 iveiv entry offset.
Date: Tue, 15 Dec 2009 18:09:31 +0100 [thread overview]
Message-ID: <200912151809.31376.IvDoorn@gmail.com> (raw)
In-Reply-To: <1260829951-27139-1-git-send-email-gwingerde@gmail.com>
On Monday 14 December 2009, Gertjan van Wingerde wrote:
> Fix typo. The index should be multiplied by the entry size, not 'and'-ed.
>
> Found via code-inspection.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index c5fe867..1a7eae3 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1323,7 +1323,7 @@
> #define PAIRWISE_KEY_ENTRY(__idx) \
> ( PAIRWISE_KEY_TABLE_BASE + ((__idx) * sizeof(struct hw_key_entry)) )
> #define MAC_IVEIV_ENTRY(__idx) \
> - ( MAC_IVEIV_TABLE_BASE + ((__idx) & sizeof(struct mac_iveiv_entry)) )
> + ( MAC_IVEIV_TABLE_BASE + ((__idx) * sizeof(struct mac_iveiv_entry)) )
> #define MAC_WCID_ATTR_ENTRY(__idx) \
> ( MAC_WCID_ATTRIBUTE_BASE + ((__idx) * sizeof(u32)) )
> #define SHARED_KEY_ENTRY(__idx) \
prev parent reply other threads:[~2009-12-15 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 22:32 [PATCH v2.6.33] rt2x00: Fix calculation of rt2800 iveiv entry offset Gertjan van Wingerde
2009-12-15 17:09 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912151809.31376.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).