* [PATCH v2.6.33] rt2x00: Fix calculation of rt2800 iveiv entry offset.
@ 2009-12-14 22:32 Gertjan van Wingerde
2009-12-15 17:09 ` Ivo van Doorn
0 siblings, 1 reply; 2+ messages in thread
From: Gertjan van Wingerde @ 2009-12-14 22:32 UTC (permalink / raw)
To: linville, users, linux-wireless; +Cc: Ivo van Doorn, Gertjan van Wingerde
Fix typo. The index should be multiplied by the entry size, not 'and'-ed.
Found via code-inspection.
Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
---
drivers/net/wireless/rt2x00/rt2800.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
index c5fe867..1a7eae3 100644
--- a/drivers/net/wireless/rt2x00/rt2800.h
+++ b/drivers/net/wireless/rt2x00/rt2800.h
@@ -1323,7 +1323,7 @@
#define PAIRWISE_KEY_ENTRY(__idx) \
( PAIRWISE_KEY_TABLE_BASE + ((__idx) * sizeof(struct hw_key_entry)) )
#define MAC_IVEIV_ENTRY(__idx) \
- ( MAC_IVEIV_TABLE_BASE + ((__idx) & sizeof(struct mac_iveiv_entry)) )
+ ( MAC_IVEIV_TABLE_BASE + ((__idx) * sizeof(struct mac_iveiv_entry)) )
#define MAC_WCID_ATTR_ENTRY(__idx) \
( MAC_WCID_ATTRIBUTE_BASE + ((__idx) * sizeof(u32)) )
#define SHARED_KEY_ENTRY(__idx) \
--
1.6.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2.6.33] rt2x00: Fix calculation of rt2800 iveiv entry offset.
2009-12-14 22:32 [PATCH v2.6.33] rt2x00: Fix calculation of rt2800 iveiv entry offset Gertjan van Wingerde
@ 2009-12-15 17:09 ` Ivo van Doorn
0 siblings, 0 replies; 2+ messages in thread
From: Ivo van Doorn @ 2009-12-15 17:09 UTC (permalink / raw)
To: Gertjan van Wingerde; +Cc: linville, users, linux-wireless
On Monday 14 December 2009, Gertjan van Wingerde wrote:
> Fix typo. The index should be multiplied by the entry size, not 'and'-ed.
>
> Found via code-inspection.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index c5fe867..1a7eae3 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1323,7 +1323,7 @@
> #define PAIRWISE_KEY_ENTRY(__idx) \
> ( PAIRWISE_KEY_TABLE_BASE + ((__idx) * sizeof(struct hw_key_entry)) )
> #define MAC_IVEIV_ENTRY(__idx) \
> - ( MAC_IVEIV_TABLE_BASE + ((__idx) & sizeof(struct mac_iveiv_entry)) )
> + ( MAC_IVEIV_TABLE_BASE + ((__idx) * sizeof(struct mac_iveiv_entry)) )
> #define MAC_WCID_ATTR_ENTRY(__idx) \
> ( MAC_WCID_ATTRIBUTE_BASE + ((__idx) * sizeof(u32)) )
> #define SHARED_KEY_ENTRY(__idx) \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-15 17:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-14 22:32 [PATCH v2.6.33] rt2x00: Fix calculation of rt2800 iveiv entry offset Gertjan van Wingerde
2009-12-15 17:09 ` Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).