linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
	Ivo van Doorn <ivdoorn@gmail.com>,
	stable@kernel.org
Subject: Re: [PATCH v2 2.6.33] rt2x00: Disable powersaving for rt61pci and rt2800pci.
Date: Tue, 15 Dec 2009 16:42:54 -0500	[thread overview]
Message-ID: <20091215214254.GG8735@tuxdriver.com> (raw)
In-Reply-To: <20091215213052.GF8735@tuxdriver.com>

On Tue, Dec 15, 2009 at 04:30:52PM -0500, John W. Linville wrote:
> On Tue, Dec 15, 2009 at 10:10:19PM +0100, Gertjan van Wingerde wrote:
> > On Tue, Dec 15, 2009 at 9:44 PM, John W. Linville
> > <linville@tuxdriver.com> wrote:
> > > On Mon, Dec 14, 2009 at 08:33:55PM +0100, Gertjan van Wingerde wrote:
> > >> We've had many reports of rt61pci failures with powersaving enabled.
> > >> Therefore, as a stop-gap measure, disable powersaving of the rt61pci
> > >> until we have found a proper solution.
> > >> Also disable powersaving on rt2800pci as it most probably will show
> > >> the same problem.
> > >>
> > >> Cc: stable@kernel.org
> > >> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> > >> ---
> > >>
> > >> John, this is an urgent fix for 2.6.33.
> > >>
> > >> v2:
> > >> - Handled feedback from Ivo:
> > >>       - Only disable powersaving by default, not permanent.
> > >>       - Also apply to rt2800pci.
> > >
> > > As posted, it will only compile on 2.6.32...
> > >
> > 
> > Me confused, as the patch was against the wireless-2.6.git tree, which
> > I thought was 2.6.33, and not 2.6.32. Please explain to which tree to
> > prepare fixes for 2.6.33.
> 
> That seems rather impossible, since wireless-2.6 failed to build with
> your patch applied. :-)  Perhaps you weren't up-to-date?

For reference:

commit 5be83de54c16944dea9c16c6a5a53c1fa75ed304
Author: Johannes Berg <johannes@sipsolutions.net>
Date:   Thu Nov 19 00:56:28 2009 +0100

    cfg80211: convert bools into flags
    
    We've accumulated a number of options for wiphys
    which make more sense as flags as we keep adding
    more. Convert the existing ones.
    
    Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2009-12-15 21:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 19:33 [PATCH v2 2.6.33] rt2x00: Disable powersaving for rt61pci and rt2800pci Gertjan van Wingerde
2009-12-14 21:34 ` Ivo van Doorn
2009-12-15 20:44 ` John W. Linville
2009-12-15 21:10   ` Gertjan van Wingerde
2009-12-15 21:30     ` John W. Linville
2009-12-15 21:42       ` John W. Linville [this message]
2009-12-15 21:44       ` Gertjan van Wingerde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091215214254.GG8735@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=gwingerde@gmail.com \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).