From: Holger Schurig <holgerschurig@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Albert Cahalan <acahalan@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
m.hirsch@raumfeld.com, libertas-dev@lists.infradead.org,
dcbw@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@kernel.org, daniel@caiaq.de,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs
Date: Wed, 16 Dec 2009 09:26:13 +0100 [thread overview]
Message-ID: <200912160926.14062.holgerschurig@gmail.com> (raw)
In-Reply-To: <787b0d920912152254r4bd3e1e2l14fbe7c1fdf42e60@mail.gmail.com>
> First of all, isn't TEST\0\0\0 simply the wrong length anyway?
> (that is, a length other than 32 is nonsense AFAIK)
No, the SSID IE in a beacon encodes also a length. So the beacons
from SSID of TEST, TEST\0 and TEST\0\0\0 are different.
This is because in the beacon, the SSID is *NOT* an u8[32], but
an IE, which is struct { u8 type, u8 length, u8 data[] };
--
http://www.holgerschurig.de
next prev parent reply other threads:[~2009-12-16 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1260650850-16163-1-git-send-email-daniel@caiaq.de>
2009-12-15 9:43 ` [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs David Miller
2009-12-15 10:03 ` Johannes Berg
2009-12-15 10:05 ` Johannes Berg
2009-12-15 10:07 ` Johannes Berg
2009-12-15 10:20 ` Daniel Mack
2009-12-15 10:31 ` Johannes Berg
2009-12-15 10:37 ` Daniel Mack
2009-12-15 10:30 ` Holger Schurig
2009-12-15 10:35 ` Johannes Berg
2009-12-16 6:54 ` Albert Cahalan
2009-12-16 8:19 ` Johannes Berg
2009-12-16 8:26 ` Holger Schurig [this message]
2009-12-16 3:58 ` Daniel Mack
2009-12-16 8:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912160926.14062.holgerschurig@gmail.com \
--to=holgerschurig@gmail.com \
--cc=acahalan@gmail.com \
--cc=daniel@caiaq.de \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.hirsch@raumfeld.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).